Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Issue 1708073002: Revert of Add check so WIN_FASTLINK will be ignored on VS 2013 (Closed)

Created:
4 years, 10 months ago by Fady Samuel
Modified:
4 years, 10 months ago
Reviewers:
scottmg, brucedawson
CC:
chromium-reviews, Peter Kasting
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add check so WIN_FASTLINK will be ignored on VS 2013 (patchset #4 id:60001 of https://codereview.chromium.org/1707813002/ ) Reason for revert: Speculative revert: https://code.google.com/p/chromium/issues/detail?id=587687 Original issue's description: > Add check so WIN_FASTLINK will be ignored on VS 2013 > > win_fastlink is helpful for improving build speeds with VS 2015 but is > not supported on VS 2013. To make it easier to enable this flag it needs > to be silently ignored by VS 2013. This makes that happen. > > BUG=440500 > > Committed: https://crrev.com/6b851bfe96519bca59237b79a003df41dcf98c3b > Cr-Commit-Position: refs/heads/master@{#375999} TBR=scottmg@chromium.org,brucedawson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440500 Committed: https://crrev.com/063f00be90f3c444179cc512140495ce4a0630fb Cr-Commit-Position: refs/heads/master@{#376062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Fady Samuel
Created Revert of Add check so WIN_FASTLINK will be ignored on VS 2013
4 years, 10 months ago (2016-02-18 01:56:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708073002/1
4 years, 10 months ago (2016-02-18 01:57:41 UTC) #2
brucedawson
On 2016/02/18 01:57:41, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 10 months ago (2016-02-18 01:59:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 01:59:57 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/063f00be90f3c444179cc512140495ce4a0630fb Cr-Commit-Position: refs/heads/master@{#376062}
4 years, 10 months ago (2016-02-18 02:00:57 UTC) #6
brucedawson
4 years, 10 months ago (2016-02-18 19:07:11 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1712713002/ by brucedawson@chromium.org.

The reason for reverting is: Revert was speculative and ultimately not related
to the failure. This CL only affects machines that have fastlink and VS 2015
enabled, which is zero build machines..

Powered by Google App Engine
This is Rietveld 408576698