Chromium Code Reviews
DescriptionRevert of Fix compositing chicken and egg problem in updateControlTints. (https://codereview.chromium.org/168193002/)
Reason for revert:
Appears to cause a number of virtual/threaded tests to time out on windows.
See: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=virtual%2Fthreaded%2Fanimations%2F3d%2Freplace-filling-transform.html
Original issue's description:
> Fix compositing chicken and egg problem in updateControlTints.
>
> updateControlTints reads compositingState, so it need to call the
> new big hammer method that updates layout and compositing state,
> updateLayoutAndStyleForPainting.
>
> Also, move the update layout call to be inside updateControlTints
> instead of FocusController::setActive so that we only do it if
> we're actually on an OS that supportsControlTints.
>
> BUG=343758
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167384
TBR=esprehn@chromium.org,abarth@chromium.org,vollick@chromium.org,ojan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=343758
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167400
Patch Set 1 #
Created: 6 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||