Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 170803010: Revert of Fix compositing chicken and egg problem in updateControlTints. (Closed)

Created:
6 years, 10 months ago by dstockwell
Modified:
6 years, 10 months ago
CC:
blink-reviews, ykyyip
Visibility:
Public.

Description

Revert of Fix compositing chicken and egg problem in updateControlTints. (https://codereview.chromium.org/168193002/) Reason for revert: Appears to cause a number of virtual/threaded tests to time out on windows. See: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=virtual%2Fthreaded%2Fanimations%2F3d%2Freplace-filling-transform.html Original issue's description: > Fix compositing chicken and egg problem in updateControlTints. > > updateControlTints reads compositingState, so it need to call the > new big hammer method that updates layout and compositing state, > updateLayoutAndStyleForPainting. > > Also, move the update layout call to be inside updateControlTints > instead of FocusController::setActive so that we only do it if > we're actually on an OS that supportsControlTints. > > BUG=343758 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167384 TBR=esprehn@chromium.org,abarth@chromium.org,vollick@chromium.org,ojan@chromium.org NOTREECHECKS=true NOTRY=true BUG=343758 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M Source/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 2 chunks +3 lines, -14 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/web/PageWidgetDelegate.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dstockwell
Created Revert of Fix compositing chicken and egg problem in updateControlTints.
6 years, 10 months ago (2014-02-19 05:35:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/170803010/1
6 years, 10 months ago (2014-02-19 05:36:02 UTC) #2
commit-bot: I haz the power
Change committed as 167400
6 years, 10 months ago (2014-02-19 05:36:13 UTC) #3
dstockwell
6 years, 10 months ago (2014-02-19 06:38:46 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/170863005/ by dstockwell@chromium.org.

The reason for reverting is: Reverting did not solve the virtual/threaded
timeouts on windows..

Powered by Google App Engine
This is Rietveld 408576698