Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 170803005: rebaseline_server: extract common unittest code, and rename tests/ -> testdata/ (Closed)

Created:
6 years, 10 months ago by epoger
Modified:
6 years, 10 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: extract common unittest code, and rename tests/ -> testdata/ NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=13499

Patch Set 1 : extract common unittest code into base_unittest.py #

Total comments: 1

Patch Set 2 : renamed tests/ -> testdata/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -1122 lines) Patch
A gm/rebaseline_server/base_unittest.py View 1 1 chunk +100 lines, -0 lines 1 comment Download
M gm/rebaseline_server/download_actuals_test.py View 2 chunks +11 lines, -90 lines 0 comments Download
M gm/rebaseline_server/results_test.py View 1 chunk +10 lines, -90 lines 0 comments Download
A + gm/rebaseline_server/testdata/.gitattributes View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/3x3bitmaprect/16998423976396106083.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/3x3bitmaprect/2054956815327187963.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/aaclip/14456211900777561488.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/aaclip/6190901827590820995.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/bigblurs/17309852422285247848.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/bigblurs/2422083043229439955.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/bitmapsource/16289727936158057543.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/bitmapsource/17503582803589749280.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/filterbitmap_checkerboard_192_192/3154864687054945306.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/filterbitmap_checkerboard_192_192/4719210487426381700.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/filterbitmap_checkerboard_32_2/15528304435129737588.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/filterbitmap_checkerboard_32_2/712827739969462165.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/fake-gm-imagefiles/bitmap-64bitMD5/texdata/3695033638604474475.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-actuals/Test-Android-GalaxyNexus-SGX540-Arm7-Release/actual-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-actuals/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/actual-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-actuals/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/actual-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-actuals/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/actual-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-actuals/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/actual-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-actuals/Test-Win7-ShuttleA-HD2000-x86_64-Debug-Trybot/actual-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-expectations/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-expectations/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-expectations/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/expected-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-expectations/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-expectations/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/expected-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-expectations/Test-Win7-ShuttleA-HD2000-x86_64-Debug-Trybot/expected-results.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/565/3x3bitmaprect.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/565/aaclip.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/565/bigblurs.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/565/bitmapsource.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/565/filterbitmap_checkerboard_192_192.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/565/filterbitmap_checkerboard_32_2.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/8888/3x3bitmaprect.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/8888/aaclip.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/8888/bigblurs.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/8888/bitmapsource.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/8888/filterbitmap_checkerboard_192_192.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/8888/filterbitmap_checkerboard_32_2.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/download_actuals_test.DownloadTest.test_fetch/gpu/texdata.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/actual/results_test.ResultsTest.test_gm/gm.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/3x3bitmaprect.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/aaclip.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/bigblurs.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/bitmapsource.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/filterbitmap_checkerboard_192_192.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/filterbitmap_checkerboard_32_2.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/3x3bitmaprect.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/aaclip.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/bigblurs.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/bitmapsource.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/filterbitmap_checkerboard_192_192.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/filterbitmap_checkerboard_32_2.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/download_actuals_test.DownloadTest.test_fetch/gpu/texdata.png View 1 Binary file 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/results_test.ResultsTest.test_gm/gm.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/rebaseline_server/tests/.gitattributes View 1 1 chunk +0 lines, -2 lines 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/3x3bitmaprect/16998423976396106083.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/3x3bitmaprect/2054956815327187963.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/aaclip/14456211900777561488.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/aaclip/6190901827590820995.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/bigblurs/17309852422285247848.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/bigblurs/2422083043229439955.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/bitmapsource/16289727936158057543.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/bitmapsource/17503582803589749280.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/filterbitmap_checkerboard_192_192/3154864687054945306.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/filterbitmap_checkerboard_192_192/4719210487426381700.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/filterbitmap_checkerboard_32_2/15528304435129737588.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/filterbitmap_checkerboard_32_2/712827739969462165.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/fake-gm-imagefiles/bitmap-64bitMD5/texdata/3695033638604474475.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-actuals/Test-Android-GalaxyNexus-SGX540-Arm7-Release/actual-results.json View 1 1 chunk +0 lines, -97 lines 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-actuals/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/actual-results.json View 1 1 chunk +0 lines, -88 lines 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-actuals/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/actual-results.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-actuals/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/actual-results.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-actuals/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/actual-results.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-actuals/Test-Win7-ShuttleA-HD2000-x86_64-Debug-Trybot/actual-results.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-expectations/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 1 1 chunk +0 lines, -109 lines 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-expectations/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -127 lines 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-expectations/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/expected-results.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-expectations/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-expectations/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/expected-results.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D gm/rebaseline_server/tests/inputs/gm-expectations/Test-Win7-ShuttleA-HD2000-x86_64-Debug-Trybot/expected-results.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/3x3bitmaprect.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/aaclip.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/bigblurs.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/bitmapsource.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/filterbitmap_checkerboard_192_192.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/565/filterbitmap_checkerboard_32_2.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/3x3bitmaprect.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/aaclip.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/bigblurs.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/bitmapsource.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/filterbitmap_checkerboard_192_192.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/8888/filterbitmap_checkerboard_32_2.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/download_actuals_test.DownloadTest.test_fetch/gpu/texdata.png View 1 Binary file 0 comments Download
D gm/rebaseline_server/tests/outputs/expected/results_test.ResultsTest.test_gm/gm.json View 1 1 chunk +0 lines, -526 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Ready for review at patchset 2. Note that all of the *code* changes (except for ...
6 years, 10 months ago (2014-02-18 20:27:01 UTC) #1
rmistry
LGTM
6 years, 10 months ago (2014-02-18 21:37:39 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 10 months ago (2014-02-19 15:35:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/170803005/30001
6 years, 10 months ago (2014-02-19 15:35:53 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 15:38:46 UTC) #5
Message was sent while issue was closed.
Change committed as 13499

Powered by Google App Engine
This is Rietveld 408576698