Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: runtime/vm/compiler.cc

Issue 1708013002: Minor fixes for background compilation (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/stub_code.cc » ('j') | runtime/vm/stub_code.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index 103792a44df86dc6a3c4d750a61f933f00561e66..10fa13a0c3576ed31e25646aaa2a4b37f1855e07 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -601,8 +601,12 @@ bool CompileParsedFunctionHelper::Compile(CompilationPipeline* pipeline) {
if (optimized()) {
// Extract type feedback before the graph is built, as the graph
// builder uses it to attach it to nodes.
- ASSERT(function.deoptimization_counter() <
- FLAG_max_deoptimization_counter_threshold);
+
+ // In background compilation the deoptimization counter may have
+ // already reached the limit.
+ ASSERT(Compiler::IsBackgroundCompilation() ||
+ function.deoptimization_counter() <
+ FLAG_max_deoptimization_counter_threshold);
siva 2016/02/17 23:12:48 maybe put parenthesis around (function.dep....() <
srdjan 2016/02/17 23:32:29 Done.
// 'Freeze' ICData in background compilation so that it does not
// change while compiling.
« no previous file with comments | « no previous file | runtime/vm/stub_code.cc » ('j') | runtime/vm/stub_code.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698