Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1708013002: Minor fixes for background compilation (Closed)

Created:
4 years, 10 months ago by srdjan
Modified:
4 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : i #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/vm/stub_code.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srdjan
4 years, 10 months ago (2016-02-17 22:49:05 UTC) #2
siva
LGTM with one comment. https://codereview.chromium.org/1708013002/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1708013002/diff/1/runtime/vm/compiler.cc#newcode609 runtime/vm/compiler.cc:609: FLAG_max_deoptimization_counter_threshold); maybe put parenthesis around ...
4 years, 10 months ago (2016-02-17 23:12:48 UTC) #3
srdjan
Committed patchset #2 (id:20001) manually as 16cb66314668504378c951fe1573dc460f3dcd42 (presubmit successful).
4 years, 10 months ago (2016-02-17 23:32:19 UTC) #5
srdjan
4 years, 10 months ago (2016-02-17 23:32:29 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1708013002/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1708013002/diff/1/runtime/vm/compiler.cc#newc...
runtime/vm/compiler.cc:609: FLAG_max_deoptimization_counter_threshold);
On 2016/02/17 23:12:48, siva wrote:
> maybe put parenthesis around (function.dep....() < FLAG_max_de...));

Done.

https://codereview.chromium.org/1708013002/diff/1/runtime/vm/stub_code.cc
File runtime/vm/stub_code.cc (right):

https://codereview.chromium.org/1708013002/diff/1/runtime/vm/stub_code.cc#new...
runtime/vm/stub_code.cc:128: cls.set_allocation_stub(stub);
On 2016/02/17 23:12:48, siva wrote:
> As discussed offline you might need a check here too.

Done.

Powered by Google App Engine
This is Rietveld 408576698