Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 17080004: Move windows specific isFixedPitch to FontPlatformData (Closed)

Created:
7 years, 6 months ago by eae
Modified:
7 years, 6 months ago
Reviewers:
Stephen White, reed1
CC:
blink-reviews, jamesr, eae+blinkwatch, danakj, Rik, Stephen Chennney, jeez, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move windows specific isFixedPitch to FontPlatformData Move windows specific isFixedPitch logic from SimpleFontData to FontPlatformDataChromiumWin. This mirrors the Skia API and allows for better abstraction. Also use SkTypeface::isFixedPitch instead of using GDI TEXTMETRIC directly if GDI_FONTS_ON_WINDOWS is disabled. BUG=250859 TEST=No new tests, covered by existing tests. R=reed@google.com, senorblanco@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -43 lines) Patch
M Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/core/platform/graphics/chromium/SimpleFontDataChromiumWin.cpp View 1 chunk +1 line, -20 lines 0 comments Download
M Source/core/platform/graphics/skia/SimpleFontDataSkia.cpp View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eae
7 years, 6 months ago (2013-06-17 17:25:00 UTC) #1
eae
Using SkTypface::isFixedPitch instead of TEXTMETRIC::tmPitchAndFamily seems to work just fine even though some of the ...
7 years, 6 months ago (2013-06-17 17:26:55 UTC) #2
reed1
lgtm
7 years, 6 months ago (2013-06-17 19:43:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/17080004/1
7 years, 6 months ago (2013-06-17 20:25:15 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-17 20:31:59 UTC) #5
Message was sent while issue was closed.
Change committed as 152583

Powered by Google App Engine
This is Rietveld 408576698