Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: build/common.gypi

Issue 1707983002: [MemSheriff] Enable tcmalloc for valgrind again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2266 matching lines...) Expand 10 before | Expand all | Expand 10 after
2277 # Without this flag, JS code causes false positive reports from MSan. 2277 # Without this flag, JS code causes false positive reports from MSan.
2278 'v8_target_arch': 'arm64', 2278 'v8_target_arch': 'arm64',
2279 }], 2279 }],
2280 2280
2281 # On valgrind bots, override the optimizer settings so we don't inline too 2281 # On valgrind bots, override the optimizer settings so we don't inline too
2282 # much and make the stacks harder to figure out. 2282 # much and make the stacks harder to figure out.
2283 # 2283 #
2284 # TODO(rnk): Kill off variables that no one else uses and just implement 2284 # TODO(rnk): Kill off variables that no one else uses and just implement
2285 # them under a build_for_tool== condition. 2285 # them under a build_for_tool== condition.
2286 ['build_for_tool=="memcheck" or build_for_tool=="tsan"', { 2286 ['build_for_tool=="memcheck" or build_for_tool=="tsan"', {
2287
2288 # tcmalloc causes Valgrind failures. Discussion in crrev.com/1642383002.
2289 'use_allocator%': 'none',
2290
2291 # gcc flags 2287 # gcc flags
2292 'mac_debug_optimization': '1', 2288 'mac_debug_optimization': '1',
2293 'mac_release_optimization': '1', 2289 'mac_release_optimization': '1',
2294 'release_optimize': '1', 2290 'release_optimize': '1',
2295 'no_gc_sections': 1, 2291 'no_gc_sections': 1,
2296 'debug_extra_cflags': '-g -fno-inline -fno-omit-frame-pointer ' 2292 'debug_extra_cflags': '-g -fno-inline -fno-omit-frame-pointer '
2297 '-fno-builtin -fno-optimize-sibling-calls', 2293 '-fno-builtin -fno-optimize-sibling-calls',
2298 'release_extra_cflags': '-g -fno-inline -fno-omit-frame-pointer ' 2294 'release_extra_cflags': '-g -fno-inline -fno-omit-frame-pointer '
2299 '-fno-builtin -fno-optimize-sibling-calls', 2295 '-fno-builtin -fno-optimize-sibling-calls',
2300 2296
(...skipping 4099 matching lines...) Expand 10 before | Expand all | Expand 10 after
6400 # settings in target dicts. SYMROOT is a special case, because many other 6396 # settings in target dicts. SYMROOT is a special case, because many other
6401 # Xcode variables depend on it, including variables such as 6397 # Xcode variables depend on it, including variables such as
6402 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6398 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6403 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6399 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6404 # files to appear (when present) in the UI as actual files and not red 6400 # files to appear (when present) in the UI as actual files and not red
6405 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6401 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6406 # and therefore SYMROOT, needs to be set at the project level. 6402 # and therefore SYMROOT, needs to be set at the project level.
6407 'SYMROOT': '<(DEPTH)/xcodebuild', 6403 'SYMROOT': '<(DEPTH)/xcodebuild',
6408 }, 6404 },
6409 } 6405 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698