Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 1707963002: Remove unused Skia includes in SkPMetric.h (Closed)

Created:
4 years, 10 months ago by bungeman-chromium
Modified:
4 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused Skia includes in SkPMetric.h The includes being removed here are not used and are also to files Skia is interested in moving to being private to Skia. Committed: https://crrev.com/00f693b39fdd38688d3ecccaa132cfd75e77ceb9 Cr-Commit-Position: refs/heads/master@{#376018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/chromeos/login/screenshot_testing/SkPMetric.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707963002/1
4 years, 10 months ago (2016-02-17 22:19:35 UTC) #2
bungeman-chromium
In the larger view, it may be that the entire screenshot_testing directory should be reviewed ...
4 years, 10 months ago (2016-02-17 22:23:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 22:42:52 UTC) #6
piman
LGTM. I have no idea about whether this is used or not... I'm only really ...
4 years, 10 months ago (2016-02-17 22:43:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707963002/1
4 years, 10 months ago (2016-02-17 22:46:36 UTC) #9
bungeman-chromium
On 2016/02/17 22:43:42, piman wrote: > LGTM. I have no idea about whether this is ...
4 years, 10 months ago (2016-02-17 22:50:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 22:55:47 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 22:57:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00f693b39fdd38688d3ecccaa132cfd75e77ceb9
Cr-Commit-Position: refs/heads/master@{#376018}

Powered by Google App Engine
This is Rietveld 408576698