content/common/input/synthetic_gesture_params.h - Issue 1707943002: Add SyntheticPointerActionParams used in Chromedriver extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/input/synthetic_gesture_params.h

Issue 1707943002: Add SyntheticPointerActionParams used in Chromedriver extension (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/input/input_param_traits_unittest.cc ('k') | content/common/input/synthetic_pointer_action_params.h » ('j') | content/common/input/synthetic_pointer_action_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/input/synthetic_gesture_params.h

diff --git a/content/common/input/synthetic_gesture_params.h b/content/common/input/synthetic_gesture_params.h

index 1c40ca98fd2a025e0d3898110e5b4bda6e1c9bb0..ac9d5653ef70803a163800850be079dd4fcb6369 100644

--- a/content/common/input/synthetic_gesture_params.h

+++ b/content/common/input/synthetic_gesture_params.h

@@ -48,8 +48,19 @@ struct CONTENT_EXPORT SyntheticGestureParams {

SMOOTH_DRAG_GESTURE,

PINCH_GESTURE,

TAP_GESTURE,

- SYNTHETIC_GESTURE_TYPE_MAX = TAP_GESTURE

+ POINTER_ACTION,

+ SYNTHETIC_GESTURE_TYPE_MAX = POINTER_ACTION

};

+ // When we send actions one by one, once we receive a PROCESS action, we will

tdresser 2016/03/02 19:37:56 Shouldn't there be a PROCESS action defined?

+ // start to dispatch a event with all the pending actions.

+ enum PointerActionType {

tdresser 2016/03/02 19:37:56 Might as well use an enum class here.

+ PRESS,

+ MOVE,

+ RELEASE,

+ POINTER_ACTION_TYPE_MAX = RELEASE

+ };

virtual GestureType GetGestureType() const = 0;

// Returns true if the specific gesture source type is supported on this