Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1707893003: Remove myself from most OWNERS files (Closed)

Created:
4 years, 10 months ago by stuartmorgan
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist-passwords_chromium.org, vabr+watchlistpasswordmanager_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove myself from most OWNERS files BUG=None Committed: https://crrev.com/8e9d9e1f002c994a3fa271a49d795f377869efb8 Cr-Commit-Position: refs/heads/master@{#378447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M base/ios/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M base/test/ios/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M build/ios/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/keyed_service/ios/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/plugin/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M testing/iossim/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/npapi/bindings/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/surface/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
stuartmorgan
It's unclear to me if I need OWNERS for this; we'll see what happens.
4 years, 10 months ago (2016-02-17 21:35:26 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years, 10 months ago (2016-02-17 23:58:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707893003/1
4 years, 10 months ago (2016-02-18 15:09:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/147365)
4 years, 10 months ago (2016-02-18 15:22:46 UTC) #7
stuartmorgan
Looks like this does need OWNERS approval +pinkerton for ui/surface +jochen for chrome, components, and ...
4 years, 10 months ago (2016-02-18 15:31:40 UTC) #8
stuartmorgan
Trying again, but actually adding the owners instead of just commenting about it :P +pinkerton ...
4 years, 9 months ago (2016-02-29 22:56:25 UTC) #10
pink (ping after 24hrs)
lgtm
4 years, 9 months ago (2016-03-01 13:14:36 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-01 14:45:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707893003/1
4 years, 9 months ago (2016-03-01 15:45:37 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 16:24:27 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 16:25:44 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8e9d9e1f002c994a3fa271a49d795f377869efb8
Cr-Commit-Position: refs/heads/master@{#378447}

Powered by Google App Engine
This is Rietveld 408576698