Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 1707843002: Drop frames until first IDR in VTVDA. (Closed)

Created:
3 years, 1 month ago by sandersd (OOO until July 31)
Modified:
3 years, 1 month ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Drop frames until first IDR in VTVDA. This allows us to decode streams that incorrectly mark every frame as a keyframe; we will drop frames until the first IDR and configure the decoder then. When this happens we log an error; it will show up in chrome://gpu (and stderr). This does mean that we are delaying decode failure (possibly indefinitely) in that case. (cherry picked from commit 8a2f5658c6301691342e302ea618c61cad5d220c) BUG=229412, 583638, 583698, 516039 TBR=dalecurtis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/75bd1db3ad32a3e3439a5811ff461581d4a037e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M content/common/gpu/media/vt_video_decode_accelerator_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator_mac.cc View 2 chunks +27 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
sandersd (OOO until July 31)
3 years, 1 month ago (2016-02-17 18:44:29 UTC) #2
sandersd (OOO until July 31)
3 years, 1 month ago (2016-02-17 18:49:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
75bd1db3ad32a3e3439a5811ff461581d4a037e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698