Issue 170783014: android: Expose content locks in RenderWidgetHostViewAndroid

Issue 170783014: android: Expose content locks in RenderWidgetHostViewAndroid (Closed)

Created:
6 years, 10 months ago by powei

Modified:
6 years, 9 months ago

Reviewers:
no sievers

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, David Trainor- moved to gerrit

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

android: Expose content locks in RenderWidgetHostViewAndroid BUG=326363

Patch Set 1 #

Patch Set 2 : missing chunks in previous patch #

Patch Set 3 : nits #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -0 lines)			Patch
M	content/browser/android/content_view_core_impl.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.cc	View	1 2	4 chunks	+19 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		2 chunks	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

no sievers

Just wondering... can we get to RWHVAndroid from the Tab class? If we could avoid ...

6 years, 10 months ago (2014-02-19 21:33:18 UTC) #2

powei

On 2014/02/19 21:33:18, sievers wrote: > Just wondering... can we get to RWHVAndroid from the ...

6 years, 10 months ago (2014-02-19 21:38:10 UTC) #3

no sievers

On 2014/02/19 21:38:10, powei wrote: > On 2014/02/19 21:33:18, sievers wrote: > > Just wondering... ...

6 years, 10 months ago (2014-02-19 21:47:46 UTC) #4

powei

6 years, 10 months ago (2014-02-19 21:50:22 UTC) #5

On 2014/02/19 21:47:46, sievers wrote:
> On 2014/02/19 21:38:10, powei wrote:
> > On 2014/02/19 21:33:18, sievers wrote:
> > > Just wondering... can we get to RWHVAndroid from the Tab class?
> > > 
> > > If we could avoid routing everything through ContentViewCore, that'd be
> great.
> > > We really want to clean and split it up, so anything we add makes it
harder
> > and
> > > we have to revisit it.
> > 
> > cc dtrainor@ to make sure. 
> > 
> > But I think ContentViewCore is the only one that can get to RWHV for now.
> 
> TabAndroid owns the WebContents, so it can get to RWHV.

Just to confirm then, you'd prefer that I plumb through TabAndroid?

Expand Messages | Collapse Messages