Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 170783012: Upstream fix for DecodeBench. (Closed)

Created:
6 years, 10 months ago by scroggo
Modified:
6 years, 10 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Upstream fix for DecodeBench. Use SkBasename to get the basename. Fixes a bug on Android where calling strrchar conflicts with Android's setting for FORTIFY_SOURCE. Committed: http://code.google.com/p/skia/source/detail?r=13511

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M bench/DecodeBench.cpp View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scroggo
6 years, 10 months ago (2014-02-19 21:03:09 UTC) #1
djsollen
lgtm
6 years, 10 months ago (2014-02-19 21:03:35 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 10 months ago (2014-02-19 21:03:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/170783012/30001
6 years, 10 months ago (2014-02-19 21:03:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/170783012/30001
6 years, 10 months ago (2014-02-20 02:14:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/170783012/30001
6 years, 10 months ago (2014-02-20 02:24:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/170783012/30001
6 years, 10 months ago (2014-02-20 03:10:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/170783012/30001
6 years, 10 months ago (2014-02-20 04:08:31 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 15:41:19 UTC) #9
Message was sent while issue was closed. 
Change committed as 13511

Powered by Google App Engine
This is Rietveld 408576698