Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 170783010: Encrypted Media: Handle blink::WebString in WebMediaPlayer*. (Closed)

Created:
6 years, 10 months ago by xhwang
Modified:
6 years, 10 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Encrypted Media: Handle blink::WebString in WebMediaPlayer*. This CL converts blink::WebString to std::string in WebMediaPlayerImpl and WebMediaPlayerAndroid so that internal chromium classes don't need to deal with blink::WebString anymore. Changes about logging: - Use base::string16 so that if non-ascii parameters can be shown correctly. - Move logging to public methods so that parameters can be logged before being converted to ASCII. BUG=252065 TEST=KeySystemsTest updated. R=ddorwin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252160

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : use base::string16 for logging #

Patch Set 4 : update tests #

Total comments: 2

Patch Set 5 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -152 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 4 9 chunks +66 lines, -42 lines 0 comments Download
M content/renderer/media/crypto/key_systems.h View 3 chunks +1 line, -8 lines 0 comments Download
M content/renderer/media/crypto/key_systems.cc View 4 chunks +9 lines, -27 lines 0 comments Download
M content/renderer/media/crypto/key_systems_unittest.cc View 1 2 3 9 chunks +24 lines, -26 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 2 10 chunks +58 lines, -36 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
xhwang
PTAL
6 years, 10 months ago (2014-02-19 19:00:30 UTC) #1
xhwang
test updated. PTAL
6 years, 10 months ago (2014-02-19 19:13:41 UTC) #2
ddorwin
The numbering on the logging comment in the description is odd. nit: These two lines ...
6 years, 10 months ago (2014-02-19 20:44:38 UTC) #3
xhwang
https://codereview.chromium.org/170783010/diff/80001/content/renderer/media/crypto/key_systems.cc File content/renderer/media/crypto/key_systems.cc (right): https://codereview.chromium.org/170783010/diff/80001/content/renderer/media/crypto/key_systems.cc#newcode36 content/renderer/media/crypto/key_systems.cc:36: On 2014/02/19 20:44:38, ddorwin wrote: > There might have ...
6 years, 10 months ago (2014-02-19 20:56:54 UTC) #4
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 10 months ago (2014-02-19 20:56:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/170783010/80001
6 years, 10 months ago (2014-02-19 21:00:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/170783010/80001
6 years, 10 months ago (2014-02-20 00:25:29 UTC) #7
xhwang
rebase only
6 years, 10 months ago (2014-02-20 00:26:19 UTC) #8
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 10 months ago (2014-02-20 00:26:45 UTC) #9
xhwang
6 years, 10 months ago (2014-02-20 02:16:25 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 manually as r252160 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698