Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 170783002: A64: Introduce 'branch types' that extend the architectural conditions. (Closed)

Created:
6 years, 10 months ago by Alexandre Rames
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Introduce 'branch types' that extend the architectural conditions. The branch types include 'always' and 'never', and types like reg_zero (CBZ) and reg_bit_clear (TBZ). This will be used by incoming improvements to the code generated for deoptimization exit points. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19497

Patch Set 1 #

Total comments: 1

Patch Set 2 : inline InvertBranchType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -0 lines) Patch
M src/a64/macro-assembler-a64.h View 1 2 chunks +55 lines, -0 lines 0 comments Download
M src/a64/macro-assembler-a64.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-a64.cc View 1 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexandre Rames
This is a first step to improving the deoptimization exit sites. It will help abstract ...
6 years, 10 months ago (2014-02-18 17:21:22 UTC) #1
Alexandre Rames
https://codereview.chromium.org/170783002/diff/1/src/a64/macro-assembler-a64.h File src/a64/macro-assembler-a64.h (right): https://codereview.chromium.org/170783002/diff/1/src/a64/macro-assembler-a64.h#newcode258 src/a64/macro-assembler-a64.h:258: Moved as a global function outside of the MacroAssembler ...
6 years, 10 months ago (2014-02-19 10:56:44 UTC) #2
ulan
Could you please reupload? The "side-by-side diffs" are empty.
6 years, 10 months ago (2014-02-19 10:58:49 UTC) #3
ulan
lgtm
6 years, 10 months ago (2014-02-19 12:03:11 UTC) #4
Alexandre Rames
6 years, 10 months ago (2014-02-19 16:13:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698