Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17078005: Move message_pump to base/message_loop. (Closed)

Created:
7 years, 6 months ago by brettw
Modified:
7 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, amit, dcheng, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, ben+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, derat+watch_chromium.org, wez+watch_chromium.org, sanjeevr, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, sergeyu+watch_chromium.org, jochen+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, tfarina, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org
Visibility:
Public.

Description

Move message_pump to base/message_loop. This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location. BUG= R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206507

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -6059 lines) Patch
M ash/display/display_change_observer_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/android/base_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/base.gyp View 5 chunks +22 lines, -22 lines 0 comments Download
M base/base.gypi View 6 chunks +18 lines, -18 lines 0 comments Download
M base/mac/scoped_sending_event.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop.h View 21 chunks +80 lines, -84 lines 0 comments Download
M base/message_loop/message_loop.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
A + base/message_loop/message_pump.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/message_loop/message_pump.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/message_loop/message_pump_android.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + base/message_loop/message_pump_android.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
A + base/message_loop/message_pump_aurax11.h View 3 chunks +9 lines, -10 lines 0 comments Download
A + base/message_loop/message_pump_aurax11.cc View 8 chunks +11 lines, -11 lines 0 comments Download
A + base/message_loop/message_pump_default.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + base/message_loop/message_pump_default.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + base/message_loop/message_pump_dispatcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/message_loop/message_pump_glib.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + base/message_loop/message_pump_glib.cc View 6 chunks +8 lines, -9 lines 0 comments Download
A + base/message_loop/message_pump_glib_unittest.cc View 26 chunks +66 lines, -66 lines 0 comments Download
A + base/message_loop/message_pump_gtk.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + base/message_loop/message_pump_gtk.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + base/message_loop/message_pump_io_ios.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + base/message_loop/message_pump_io_ios.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/message_loop/message_pump_io_ios_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/message_loop/message_pump_libevent.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + base/message_loop/message_pump_libevent.cc View 5 chunks +4 lines, -8 lines 0 comments Download
A + base/message_loop/message_pump_libevent_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + base/message_loop/message_pump_mac.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + base/message_loop/message_pump_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + base/message_loop/message_pump_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/message_loop/message_pump_ozone.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + base/message_loop/message_pump_ozone.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + base/message_loop/message_pump_win.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + base/message_loop/message_pump_win.cc View 4 chunks +7 lines, -7 lines 0 comments Download
D base/message_pump.h View 1 chunk +0 lines, -129 lines 0 comments Download
D base/message_pump.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D base/message_pump_android.h View 1 chunk +0 lines, -45 lines 0 comments Download
D base/message_pump_android.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D base/message_pump_aurax11.h View 1 chunk +0 lines, -123 lines 0 comments Download
D base/message_pump_aurax11.cc View 1 chunk +0 lines, -307 lines 0 comments Download
D base/message_pump_default.h View 1 chunk +0 lines, -42 lines 0 comments Download
D base/message_pump_default.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D base/message_pump_dispatcher.h View 1 chunk +0 lines, -32 lines 0 comments Download
D base/message_pump_glib.h View 1 chunk +0 lines, -110 lines 0 comments Download
D base/message_pump_glib.cc View 1 chunk +0 lines, -335 lines 0 comments Download
D base/message_pump_glib_unittest.cc View 1 chunk +0 lines, -580 lines 0 comments Download
D base/message_pump_gtk.h View 1 chunk +0 lines, -76 lines 0 comments Download
D base/message_pump_gtk.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D base/message_pump_io_ios.h View 1 chunk +0 lines, -142 lines 0 comments Download
D base/message_pump_io_ios.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D base/message_pump_io_ios_unittest.cc View 1 chunk +0 lines, -188 lines 0 comments Download
D base/message_pump_libevent.h View 1 chunk +0 lines, -179 lines 0 comments Download
D base/message_pump_libevent.cc View 1 chunk +0 lines, -379 lines 0 comments Download
D base/message_pump_libevent_unittest.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D base/message_pump_mac.h View 1 chunk +0 lines, -337 lines 0 comments Download
D base/message_pump_mac.mm View 1 chunk +0 lines, -701 lines 0 comments Download
D base/message_pump_observer.h View 1 chunk +0 lines, -47 lines 0 comments Download
D base/message_pump_ozone.h View 1 chunk +0 lines, -52 lines 0 comments Download
D base/message_pump_ozone.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D base/message_pump_win.h View 1 chunk +0 lines, -396 lines 0 comments Download
D base/message_pump_win.cc View 1 chunk +0 lines, -686 lines 0 comments Download
M base/test/mock_chrome_application_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_support_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/test_support_ios.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M base/win/text_services_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_application_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_animation_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_overlay_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/run_loop_testing.mm View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/display/real_output_configurator_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/power_save_blocker_x11.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/udev_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/gles2_texture_to_egl_image_translator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/shell_application_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/browser_test_message_pump_android.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_linux.h View 1 chunk +8 lines, -7 lines 0 comments Download
M remoting/host/local_input_monitor_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/posix/signal_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/bench/bench_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/device_list_updater_aurax11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/env.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window_host_x11.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard_aurax11.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ozone/event_converter_ozone.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ozone/event_converter_ozone.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ozone/event_factory_ozone.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ozone/event_factory_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ozone/touch_event_converter_ozone.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/x/events_x.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/selection_requestor.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/x11_atom_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/drt_application_mac.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years, 6 months ago (2013-06-14 20:52:00 UTC) #1
sky
LGTM
7 years, 6 months ago (2013-06-14 20:57:35 UTC) #2
brettw
7 years, 6 months ago (2013-06-14 22:51:38 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r206507.

Powered by Google App Engine
This is Rietveld 408576698