Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: tools/android/loading/trace_recorder.py

Issue 1707793002: sandwich: Refactor to use more existing code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses benoit's comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/android/loading/run_sandwich.py ('k') | tools/android/loading/tracing.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/loading/trace_recorder.py
diff --git a/tools/android/loading/trace_recorder.py b/tools/android/loading/trace_recorder.py
index 34293f8d8c0eabd624e61521b25ae90bb549010a..0da057ff7e0ecae934053e7b91e0d9e981f60ac3 100755
--- a/tools/android/loading/trace_recorder.py
+++ b/tools/android/loading/trace_recorder.py
@@ -30,20 +30,22 @@ import request_track
import tracing
-def MonitorUrl(connection, url, clear_cache=False):
+def MonitorUrl(connection, url, clear_cache=False,
+ categories=tracing.DEFAULT_CATEGORIES):
"""Monitor a URL via a trace recorder.
Args:
connection: A device_monitor.DevToolsConnection instance.
url: url to navigate to as string.
clear_cache: boolean indicating if cache should be cleared before loading.
+ categories: List of tracing event categories to record.
Returns:
loading_trace.LoadingTrace.
"""
page = page_track.PageTrack(connection)
request = request_track.RequestTrack(connection)
- trace = tracing.TracingTrack(connection)
+ trace = tracing.TracingTrack(connection, categories=categories)
connection.SetUpMonitoring()
if clear_cache:
connection.ClearCache()
« no previous file with comments | « tools/android/loading/run_sandwich.py ('k') | tools/android/loading/tracing.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698