Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1707723002: Revert of Added ResourcePriorities field trial to the waterfall testing config (Closed)

Created:
4 years, 10 months ago by Pat Meenan
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added ResourcePriorities field trial to the waterfall testing config in preparation for launch (patchset #1 id:1 of https://codereview.chromium.org/1700253002/ ) Reason for revert: Looks like the ResourcePriorities code is slowing down the service workers micro benchmark pretty significantly (and unexpectedly). Disabling it until we can understand and fix why. Original issue's description: > Added ResourcePriorities field trial to the waterfall testing config in preparation for launch > > BUG=521744 > > Committed: https://crrev.com/64bc5ddf872133174294d6bbcd4536c06c8f6398 > Cr-Commit-Position: refs/heads/master@{#375644} TBR=asvitkine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=521744 Committed: https://crrev.com/37b8253bbb12ee475dc053a25ba3526c5c82ef99 Cr-Commit-Position: refs/heads/master@{#375899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Pat Meenan
Created Revert of Added ResourcePriorities field trial to the waterfall testing config in preparation for ...
4 years, 10 months ago (2016-02-17 16:16:39 UTC) #1
Alexei Svitkine (slow)
lgtm
4 years, 10 months ago (2016-02-17 16:22:49 UTC) #3
Pat Meenan
4 years, 9 months ago (2016-03-09 20:10:59 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1784553002/ by pmeenan@chromium.org.

The reason for reverting is: Re-landing now that a fix has landed:
https://codereview.chromium.org/1783433003/.

Powered by Google App Engine
This is Rietveld 408576698