Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1707673002: fast sk4f <-> sk4i SSE methods (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fast sk4f <-> sk4i SSE methods BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707673002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/0cf795fd1135babe0ee0b3585f3ad49a02fe1387

Patch Set 1 #

Patch Set 2 : back #

Total comments: 1

Patch Set 3 : ffff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/opts/SkNx_sse.h View 1 chunk +7 lines, -0 lines 0 comments Download
M tests/SkNxTest.cpp View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mtklein_C
4 years, 10 months ago (2016-02-17 14:49:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707673002/20001
4 years, 10 months ago (2016-02-17 14:49:58 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-17 14:50:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/6273)
4 years, 10 months ago (2016-02-17 14:52:32 UTC) #8
reed1
lgtm https://codereview.chromium.org/1707673002/diff/20001/tests/SkNxTest.cpp File tests/SkNxTest.cpp (right): https://codereview.chromium.org/1707673002/diff/20001/tests/SkNxTest.cpp#newcode241 tests/SkNxTest.cpp:241: Sk4f f(-2.3, 1.0, 0.45, 0.6); need those annoying ...
4 years, 10 months ago (2016-02-17 14:55:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707673002/40001
4 years, 10 months ago (2016-02-17 15:00:52 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 15:23:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0cf795fd1135babe0ee0b3585f3ad49a02fe1387

Powered by Google App Engine
This is Rietveld 408576698