Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1707653003: [runtime] Don't compute the hash for linear search in descriptor array (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Don't compute the hash for linear search in descriptor array I replaced the hidden string with hidden_properties_symbol, so we don't need the extra hash-check anymore. This is slightly faster anyway. BUG= Committed: https://crrev.com/c383fc20ca66875fc5e5b9b7a6f848cbe2aaef17 Cr-Commit-Position: refs/heads/master@{#34086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/objects-inl.h View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-17 14:55:35 UTC) #2
Camillo Bruni
lgtm
4 years, 10 months ago (2016-02-17 15:27:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707653003/1
4 years, 10 months ago (2016-02-17 15:37:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 16:18:24 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 16:18:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c383fc20ca66875fc5e5b9b7a6f848cbe2aaef17
Cr-Commit-Position: refs/heads/master@{#34086}

Powered by Google App Engine
This is Rietveld 408576698