Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1707643002: Fixed comment about :host in SelectorChecker. (Closed)

Created:
4 years, 10 months ago by rune
Modified:
4 years, 10 months ago
Reviewers:
kochi
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed comment about :host in SelectorChecker. - Only non-functional :host has no selector list. - Removed misplaced specificity comment. R=kochi@chromium.org Committed: https://crrev.com/56a7be18541c703c3d013a2c711ca4767f501549 Cr-Commit-Position: refs/heads/master@{#376076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
rune
4 years, 10 months ago (2016-02-17 10:34:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707643002/1
4 years, 10 months ago (2016-02-17 10:34:58 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 11:58:45 UTC) #6
kochi
lgtm
4 years, 10 months ago (2016-02-18 02:30:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707643002/1
4 years, 10 months ago (2016-02-18 02:33:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 02:41:51 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 02:42:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56a7be18541c703c3d013a2c711ca4767f501549
Cr-Commit-Position: refs/heads/master@{#376076}

Powered by Google App Engine
This is Rietveld 408576698