MD Settings: Start device page

MD Settings: Start device page

Add the Device section, with a partially implemented
Touchpad page.

Device section: http://i.imgur.com/AYLFAQa.png
Touchpad settings: http://i.imgur.com/Lu3lxnO.png

BUG=546834
Committed: https://crrev.com/9013bd49fd7992393947eb6661457ef0d7636e74
Cr-Commit-Position: refs/heads/master@{#376532}

[michaelpg, 2016-02-17 04:56:23]

Description was changed from

==========
MD Settings: Start device page.

BUG=546834
==========

to

==========
MD Settings: Start device page

BUG=546834
==========

[michaelpg, 2016-02-17 05:05:11]

michaelpg@chromium.org changed reviewers:
+ dschuyler@chromium.org

[michaelpg, 2016-02-17 05:05:12]

Dave, could you take a preliminary look, let me know if I'm using the new
settings classes correctly?

The Touchpad page is implemented but incomplete. Keyboard is
just there to show what the list looks like.

Device section: http://i.imgur.com/AYLFAQa.png
Touchpad settings: http://i.imgur.com/Lu3lxnO.png

[michaelpg, 2016-02-17 05:05:37]

Description was changed from

==========
MD Settings: Start device page

BUG=546834
==========

to

==========
MD Settings: Start device page

Add the Device section, with a partially implemented
Touchpad page.

Device section: http://i.imgur.com/AYLFAQa.png
Touchpad settings: http://i.imgur.com/Lu3lxnO.png


BUG=546834
==========

[dschuyler, 2016-02-17 20:11:17]

On 2016/02/17 05:05:12, michaelpg wrote:
> Dave, could you take a preliminary look, let me know if I'm using the new
> settings classes correctly?
> 
> The Touchpad page is implemented but incomplete. Keyboard is
> just there to show what the list looks like.
> 
> Device section: http://i.imgur.com/AYLFAQa.png
> Touchpad settings: http://i.imgur.com/Lu3lxnO.png

Thanks Michael, I looked it over - paying extra attention to the settings
classes.  It looks okay to me, though I'm also dealing with the flu at the
moment.  I'd suggest switching to another reviewer so that this may 
get a 'real' review sooner.

[dschuyler, 2016-02-17 20:11:24]

https://codereview.chromium.org/1707613002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/compiled_resources2.gyp
(right):

https://codereview.chromium.org/1707613002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/compiled_resources2.gyp:10:
#'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:cr',
Can this line be removed or commented to say why it's commented out.

[michaelpg, 2016-02-17 23:33:39]

michaelpg@chromium.org changed reviewers:
+ tommycli@chromium.org

[michaelpg, 2016-02-17 23:33:40]

michaelpg@chromium.org changed required reviewers:
+ tommycli@chromium.org

[michaelpg, 2016-02-17 23:33:40]

+tommycli for full review

https://codereview.chromium.org/1707613002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/compiled_resources2.gyp
(right):

https://codereview.chromium.org/1707613002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/compiled_resources2.gyp:10:
#'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:cr',
On 2016/02/17 20:11:24, dschuyler wrote:
> Can this line be removed or commented to say why it's commented out.

Oops, forgot to finish this file. Thanks!

[tommycli, 2016-02-17 23:56:37]

lgtm. I didn't find any flaws in it.

https://codereview.chromium.org/1707613002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/touchpad.html (right):

https://codereview.chromium.org/1707613002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/touchpad.html:9: <!--
TODO(michaelpg): touchpad speed slider. -->
nit: Add touchpad speed slider.

https://codereview.chromium.org/1707613002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/device_page_browsertest_chromeos.js
(right):

https://codereview.chromium.org/1707613002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/device_page_browsertest_chromeos.js:38:
expectTrue(!!deviceSection);
This test just tests that it exists?

[michaelpg, 2016-02-17 23:57:42]

https://codereview.chromium.org/1707613002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/device_page_browsertest_chromeos.js
(right):

https://codereview.chromium.org/1707613002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/device_page_browsertest_chromeos.js:38:
expectTrue(!!deviceSection);
On 2016/02/17 23:56:37, tommycli wrote:
> This test just tests that it exists?

yeah. there's not much else to do right now. I thought about testing that the
Touchpad subpage opens, but couldn't find an existing example and didn't want to
spend too much time on it before more functionality was there.

[michaelpg, 2016-02-19 08:03:13]

https://codereview.chromium.org/1707613002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/touchpad.html (right):

https://codereview.chromium.org/1707613002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/touchpad.html:9: <!--
TODO(michaelpg): touchpad speed slider. -->
On 2016/02/17 23:56:37, tommycli wrote:
> nit: Add touchpad speed slider.

Done.

[michaelpg, 2016-02-19 08:03:25]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-02-19 08:03:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/1707613002/#ps60001
(title: "comments, rebase")

[commit-bot: I haz the power, 2016-02-19 08:04:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707613002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707613002/60001

[commit-bot: I haz the power, 2016-02-19 10:21:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 10:21:43]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[michaelpg, 2016-02-19 19:31:54]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-02-19 19:35:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707613002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707613002/60001

[commit-bot: I haz the power, 2016-02-19 21:10:04]

Description was changed from

==========
MD Settings: Start device page

Add the Device section, with a partially implemented
Touchpad page.

Device section: http://i.imgur.com/AYLFAQa.png
Touchpad settings: http://i.imgur.com/Lu3lxnO.png


BUG=546834
==========

to

==========
MD Settings: Start device page

Add the Device section, with a partially implemented
Touchpad page.

Device section: http://i.imgur.com/AYLFAQa.png
Touchpad settings: http://i.imgur.com/Lu3lxnO.png


BUG=546834
==========

[commit-bot: I haz the power, 2016-02-19 21:10:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-19 21:11:16]

Description was changed from

==========
MD Settings: Start device page

Add the Device section, with a partially implemented
Touchpad page.

Device section: http://i.imgur.com/AYLFAQa.png
Touchpad settings: http://i.imgur.com/Lu3lxnO.png


BUG=546834
==========

to

==========
MD Settings: Start device page

Add the Device section, with a partially implemented
Touchpad page.

Device section: http://i.imgur.com/AYLFAQa.png
Touchpad settings: http://i.imgur.com/Lu3lxnO.png

BUG=546834

Committed: https://crrev.com/9013bd49fd7992393947eb6661457ef0d7636e74
Cr-Commit-Position: refs/heads/master@{#376532}
==========

[commit-bot: I haz the power, 2016-02-19 21:11:17]

Patchset 4 (id:??) landed as
https://crrev.com/9013bd49fd7992393947eb6661457ef0d7636e74
Cr-Commit-Position: refs/heads/master@{#376532}