Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1707603002: Removes UIActionSheet implementation of CRUActionSheetController (Closed)

Created:
4 years, 10 months ago by pkl (ping after 24h if needed)
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes UIActionSheet implementation of CRUActionSheetController UIActionSheet has been deprecated starting from iOS 8. BUG=586874 Committed: https://crrev.com/813914ca81e86ec5be355b859848e0f700ee7473 Cr-Commit-Position: refs/heads/master@{#375831}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -163 lines) Patch
M ui/base/ios/cru_context_menu_controller.mm View 4 chunks +2 lines, -163 lines 1 comment Download

Messages

Total messages: 13 (5 generated)
pkl (ping after 24h if needed)
4 years, 10 months ago (2016-02-17 04:46:21 UTC) #2
sdefresne
lgtm
4 years, 10 months ago (2016-02-17 07:46:17 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707603002/1
4 years, 10 months ago (2016-02-17 07:52:20 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 08:34:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707603002/1
4 years, 10 months ago (2016-02-17 08:43:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 08:52:53 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/813914ca81e86ec5be355b859848e0f700ee7473 Cr-Commit-Position: refs/heads/master@{#375831}
4 years, 10 months ago (2016-02-17 08:54:14 UTC) #12
Eugene But (OOO till 7-30)
4 years, 10 months ago (2016-02-17 15:06:24 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/1707603002/diff/1/ui/base/ios/cru_context_men...
File ui/base/ios/cru_context_menu_controller.mm (right):

https://codereview.chromium.org/1707603002/diff/1/ui/base/ios/cru_context_men...
ui/base/ios/cru_context_menu_controller.mm:30: @interface CRUAlertController :
NSObject<CRUContextMenuControllerImpl>
There is no need for using a bridge pattern now and CRUAlertController can be
folded into CRUContextMenuController. Peter could you please either file a bug
with TODO or clean this up in a separate CL. Otherwise this unnecessary
complication will remain here for a long time.

Powered by Google App Engine
This is Rietveld 408576698