Implementing blink side of 'invalid' AutocompleteErrorEvent#reason

Implementing blink side of 'invalid' AutocompleteErrorEvent#reason

R=tkent@chromium.org
BUG=168967
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152699

[tkent, 2013-06-19 00:52:08]

not lgtm.

HTMLFormElement::checkValidity should not exposed to Chromium.
checkValidity dispatches 'invalid' events. Event handlers for them are executed
unexpectedly if Chromium calls checkValidity.

[Dan Beam, 2013-06-19 02:16:27]

bool -> enum, ptal

[tkent, 2013-06-19 02:24:03]

https://codereview.chromium.org/17076013/diff/8001/Source/core/html/HTMLFormC...
File Source/core/html/HTMLFormControlElement.cpp (right):

https://codereview.chromium.org/17076013/diff/8001/Source/core/html/HTMLFormC...
Source/core/html/HTMLFormControlElement.cpp:408: bool needsDefaultAction =
dispatchEvents == CheckValidityDispatchEventsAllowed &&
dispatchEvent(Event::create(eventNames().invalidEvent, false, true));
We can exit from this function earlier if CheckValidityDispatchEventsNone.

if (!willValidate() || isValidFormControlElement())
    return true;
if (dispatchEvents == CheckValidityDispatchEventsNone)
    return false;
// An event handler ...

https://codereview.chromium.org/17076013/diff/8001/Source/core/html/HTMLFormE...
File Source/core/html/HTMLFormElement.h (right):

https://codereview.chromium.org/17076013/diff/8001/Source/core/html/HTMLFormE...
Source/core/html/HTMLFormElement.h:158: bool
checkInvalidControlsAndCollectUnhandled(Vector<RefPtr<FormAssociatedElement> >*,
HTMLFormControlElement::CheckValidityDispatchEvents dispatchInvalidEvents);
Adding a default argument makes the code simpler.
If we add dispatchInvalidEvents = CheckValidityDispatchEventsAllowed, we don't
need to update HTMLFormElement::validateInteractively and
HTMLFormElement::checkValidity.

[Dan Beam, 2013-06-19 02:42:39]

https://codereview.chromium.org/17076013/diff/8001/Source/core/html/HTMLFormC...
File Source/core/html/HTMLFormControlElement.cpp (right):

https://codereview.chromium.org/17076013/diff/8001/Source/core/html/HTMLFormC...
Source/core/html/HTMLFormControlElement.cpp:408: bool needsDefaultAction =
dispatchEvents == CheckValidityDispatchEventsAllowed &&
dispatchEvent(Event::create(eventNames().invalidEvent, false, true));
On 2013/06/19 02:24:03, tkent wrote:
> We can exit from this function earlier if CheckValidityDispatchEventsNone.
> 
> if (!willValidate() || isValidFormControlElement())
>     return true;
> if (dispatchEvents == CheckValidityDispatchEventsNone)
>     return false;
> // An event handler ...

Done.

https://codereview.chromium.org/17076013/diff/8001/Source/core/html/HTMLFormE...
File Source/core/html/HTMLFormElement.h (right):

https://codereview.chromium.org/17076013/diff/8001/Source/core/html/HTMLFormE...
Source/core/html/HTMLFormElement.h:158: bool
checkInvalidControlsAndCollectUnhandled(Vector<RefPtr<FormAssociatedElement> >*,
HTMLFormControlElement::CheckValidityDispatchEvents dispatchInvalidEvents);
On 2013/06/19 02:24:03, tkent wrote:
> Adding a default argument makes the code simpler.
> If we add dispatchInvalidEvents = CheckValidityDispatchEventsAllowed, we don't
> need to update HTMLFormElement::validateInteractively and
> HTMLFormElement::checkValidity.

Done.

[tkent, 2013-06-19 03:07:39]

lgtm

[commit-bot: I haz the power, 2013-06-19 03:36:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/17076013/7005

[commit-bot: I haz the power, 2013-06-19 05:40:45]

Change committed as 152699