Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1707593002: Get rid of some copy/paste in resolver_test. (Closed)

Created:
4 years, 10 months ago by Bob Nystrom
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -268 lines) Patch
M pkg/analyzer/test/generated/resolver_test.dart View 37 chunks +181 lines, -268 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Bob Nystrom
I was digging through the error reporting code and stumbled onto some kind of redundant ...
4 years, 10 months ago (2016-02-17 01:36:45 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-17 03:42:18 UTC) #3
Jennifer Messerly
LGTM, awesome!
4 years, 10 months ago (2016-02-17 16:39:28 UTC) #4
Bob Nystrom
4 years, 10 months ago (2016-02-17 19:22:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
47119ed7fe8735c45d9c1c82bb318812739f9ea9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698