Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1843)

Unified Diff: components/gcm_driver/gcm_stats_recorder_impl_unittest.cc

Issue 1707513002: Add various UMA histograms for measuring GCM crypto performance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcm-remove-info
Patch Set: android fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_stats_recorder_impl.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_stats_recorder_impl_unittest.cc
diff --git a/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc b/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc
index 5c6fe253fc3942f32d6ff1af06fc0af5318b93c2..eae8909a3534bc66de1a53075e0a2c4e20ac0638 100644
--- a/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc
+++ b/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc
@@ -99,8 +99,8 @@ static const char kNotifySendStatusDetails[] = "Msg size: 99 bytes, TTL: 7";
static const char kIncomingSendErrorEvent[] = "Received 'send error' msg";
static const char kIncomingSendErrorDetails[] = "";
-static const GCMEncryptionProvider::DecryptionFailure kDecryptionFailureReason =
- GCMEncryptionProvider::DECRYPTION_FAILURE_INVALID_PAYLOAD;
+static const GCMEncryptionProvider::DecryptionResult kDecryptionResultFailure =
+ GCMEncryptionProvider::DECRYPTION_RESULT_INVALID_PAYLOAD;
} // namespace
@@ -302,8 +302,8 @@ class GCMStatsRecorderImplTest : public testing::Test {
EXPECT_EQ(kAppId, queue.front().app_id) << remark;
EXPECT_EQ(
- GCMEncryptionProvider::ToDecryptionFailureDetailsString(
- kDecryptionFailureReason),
+ GCMEncryptionProvider::ToDecryptionResultDetailsString(
+ kDecryptionResultFailure),
queue.front().details) << remark;
}
@@ -547,7 +547,7 @@ TEST_F(GCMStatsRecorderImplTest, RecordSendingTest) {
}
TEST_F(GCMStatsRecorderImplTest, RecordDecryptionFailureTest) {
- recorder_.RecordDecryptionFailure(kAppId, kDecryptionFailureReason);
+ recorder_.RecordDecryptionFailure(kAppId, kDecryptionResultFailure);
VerifyRecordedDecryptionFailureCount(1);
VerifyRecordedDecryptionFailure("1st call");
« no previous file with comments | « components/gcm_driver/gcm_stats_recorder_impl.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698