components/gcm_driver/gcm_stats_recorder_impl.cc - Issue 1707513002: Add various UMA histograms for measuring GCM crypto performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_stats_recorder_impl.cc

Issue 1707513002: Add various UMA histograms for measuring GCM crypto performance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcm-remove-info

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/gcm_driver/gcm_driver.cc ('K') | « components/gcm_driver/gcm_stats_recorder_impl.h ('k') | components/gcm_driver/gcm_stats_recorder_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_stats_recorder_impl.cc

diff --git a/components/gcm_driver/gcm_stats_recorder_impl.cc b/components/gcm_driver/gcm_stats_recorder_impl.cc

index 803e6baff0c2adbac480c48957c234375f58f408..d632bd397f50bf5b9649c0c7336a6032cccce4e0 100644

--- a/components/gcm_driver/gcm_stats_recorder_impl.cc

+++ b/components/gcm_driver/gcm_stats_recorder_impl.cc

@@ -173,7 +173,9 @@ void GCMStatsRecorderImpl::NotifyActivityRecorded() {

void GCMStatsRecorderImpl::RecordDecryptionFailure(

const std::string& app_id,

- GCMEncryptionProvider::DecryptionFailure reason) {

+ GCMEncryptionProvider::DecryptionResult result) {

+ DCHECK_NE(result, GCMEncryptionProvider::DECRYPTION_RESULT_UNENCRYPTED);

+ DCHECK_NE(result, GCMEncryptionProvider::DECRYPTION_RESULT_DECRYPTED);

if (!is_recording_)

return;

@@ -182,7 +184,7 @@ void GCMStatsRecorderImpl::RecordDecryptionFailure(

&decryption_failure_activities_, data);

inserted_data->app_id = app_id;

inserted_data->details =

- GCMEncryptionProvider::ToDecryptionFailureDetailsString(reason);

+ GCMEncryptionProvider::ToDecryptionResultDetailsString(result);

NotifyActivityRecorded();

}