components/gcm_driver/fake_gcm_client.cc - Issue 1707513002: Add various UMA histograms for measuring GCM crypto performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/fake_gcm_client.cc

Issue 1707513002: Add various UMA histograms for measuring GCM crypto performance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcm-remove-info

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/fake_gcm_client.cc

diff --git a/components/gcm_driver/fake_gcm_client.cc b/components/gcm_driver/fake_gcm_client.cc

index ecd7f357bad5caeddcf8909007df8ab76cc81f1b..ef2acf05aa3b33ef73895c92fafc1e6882359a65 100644

--- a/components/gcm_driver/fake_gcm_client.cc

+++ b/components/gcm_driver/fake_gcm_client.cc

@@ -160,8 +160,8 @@ void FakeGCMClient::Send(const std::string& app_id,

void FakeGCMClient::RecordDecryptionFailure(

const std::string& app_id,

- GCMEncryptionProvider::DecryptionFailure reason) {

- recorder_.RecordDecryptionFailure(app_id, reason);

+ GCMEncryptionProvider::DecryptionResult result) {

+ recorder_.RecordDecryptionFailure(app_id, result);

johnme 2016/02/18 17:59:38 Why does the fake record stats? Is this for a test

Peter Beverloo 2016/02/18 21:22:59 Yes. See GCMDriverFunctionalTest.EncryptedMessageR

}

void FakeGCMClient::SetRecording(bool recording) {

« no previous file with comments | « components/gcm_driver/fake_gcm_client.h ('k') | components/gcm_driver/fake_gcm_driver.h » ('j') | components/gcm_driver/gcm_driver.cc » ('J')