Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1707453003: further skiaserve image performance improvements (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
Reviewers:
joshualitt, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M tools/debugger/SkDebugCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skiaserve/skiaserve.cpp View 5 chunks +20 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707453003/1
4 years, 10 months ago (2016-02-16 20:53:19 UTC) #3
ethannicholas
4 years, 10 months ago (2016-02-16 20:53:34 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 21:21:43 UTC) #7
joshualitt
On 2016/02/16 21:21:43, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 10 months ago (2016-02-16 21:29:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707453003/1
4 years, 10 months ago (2016-02-17 17:16:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/68c063bf11c91b2b3b15cb93168cf2af9b2c642d
4 years, 10 months ago (2016-02-17 17:17:39 UTC) #12
joshualitt
On 2016/02/17 17:17:39, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 10 months ago (2016-02-17 18:07:39 UTC) #13
ethannicholas
4 years, 10 months ago (2016-02-17 18:30:07 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1708683002/ by ethannicholas@google.com.

The reason for reverting is: Broke skiaserve GPU rendering.

Powered by Google App Engine
This is Rietveld 408576698