third_party/WebKit/Source/core/dom/Node.cpp - Issue 1707443003: Consider slots as a focus scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 1707443003: Consider slots as a focus scope (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactoring in response to review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Node.cpp

diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp

index a9c7a70153d49d47c19a290c795bdc87495ab167..6c0713b3ea2e6e0c76e7ee62499d338d6f8344c7 100644

--- a/third_party/WebKit/Source/core/dom/Node.cpp

+++ b/third_party/WebKit/Source/core/dom/Node.cpp

@@ -2276,6 +2276,8 @@ PassRefPtrWillBeRawPtr<StaticNodeList> Node::getDestinationInsertionPoints()

HTMLSlotElement* Node::assignedSlot() const

{

ASSERT(!needsDistributionRecalc());

+ if (!isChildOfV1ShadowHost())

+ return nullptr;

kochi 2016/03/04 04:16:30 isChildOfV1ShadowHost() is almost identical to lin

yuzuchan 2016/03/04 06:44:01 Done.

if (ElementShadow* shadow = parentElementShadow()) {

if (shadow->isV1())

return shadow->assignedSlotFor(*this);