Consider slots as a focus scope

third_party/WebKit/Source/core/page/FocusController.cpp

 /*
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nuanti Ltd.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 10 matching lines @@
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/page/FocusController.h"
 
 #include "core/HTMLNames.h"
 #include "core/dom/AXObjectCache.h"
+#include "core/dom/AssignedElementTraversal.h"
+#include "core/dom/ContainerNode.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/ElementTraversal.h"
-#include "core/dom/NodeTraversal.h"
 #include "core/dom/Range.h"
 #include "core/dom/shadow/ElementShadow.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/editing/EditingUtilities.h" // For firstPositionInOrBeforeNode
 #include "core/editing/Editor.h"
 #include "core/editing/FrameSelection.h"
 #include "core/events/Event.h"
 #include "core/frame/FrameClient.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalDOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/RemoteFrame.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLAreaElement.h"
 #include "core/html/HTMLImageElement.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/html/HTMLShadowElement.h"
+#include "core/html/HTMLSlotElement.h"
 #include "core/html/HTMLTextFormControlElement.h"
 #include "core/input/EventHandler.h"
 #include "core/page/ChromeClient.h"
 #include "core/page/FrameTree.h"
 #include "core/page/Page.h"
 #include "core/layout/HitTestResult.h"
 #include "core/page/SpatialNavigation.h"
 #include <limits>
 
 namespace blink {
 
 using namespace HTMLNames;
 
 namespace {
 
 inline bool isShadowInsertionPointFocusScopeOwner(Element& element)
 {
     return isActiveShadowInsertionPoint(element) && toHTMLShadowElement(element).olderShadowRoot();
 }
 
-class FocusNavigationScope {
+class ScopedFocusNavigation {
     STACK_ALLOCATED();
 public:
-    Element* firstElement() const;
-    Element* lastElement() const;
+    Element* currentElement() const;
+    void currentElement(Element*);

[kochi, 2016/03/01 12:55:41]

setCurrentElement()

[yuzuchan, 2016/03/02 09:02:15]

Done.

+    Element* nextElement();
+    Element* previousElement();

[kochi, 2016/03/01 12:55:40]

Looking at current usage of these 2 methods, I'd be alluded to change the return
type to
void and rename to moveToNext()/moveToPrevious().

[yuzuchan, 2016/03/02 09:02:15]

Done.

+    Element* firstElement();
+    Element* lastElement();
     Element* owner() const;
-    static FocusNavigationScope focusNavigationScopeOf(const Element&);
-    static FocusNavigationScope ownedByNonFocusableFocusScopeOwner(Element&);
-    static FocusNavigationScope ownedByShadowHost(const Element&);
-    static FocusNavigationScope ownedByShadowInsertionPoint(HTMLShadowElement&);
-    static FocusNavigationScope ownedByIFrame(const HTMLFrameOwnerElement&);
+    static ScopedFocusNavigation focusNavigationScopeOf(const Element&, const Element*);

[kochi, 2016/03/01 12:55:41]

If a function has 2 same types (or similar types), you need to have parameter
name so they are
distinguishable.

[yuzuchan, 2016/03/02 09:02:14]

Done.

[yuzuchan, 2016/03/02 09:02:15]

Done.

+    static ScopedFocusNavigation ownedByNonFocusableFocusScopeOwner(Element&);
+    static ScopedFocusNavigation ownedByShadowHost(const Element&);
+    static ScopedFocusNavigation ownedByShadowInsertionPoint(HTMLShadowElement&);
+    static ScopedFocusNavigation ownedByHTMLSlotElement(HTMLSlotElement&);

[kochi, 2016/03/01 12:55:41]

Is it possible to make this parameter const reference?

[yuzuchan, 2016/03/02 09:02:15]

Done.

+    static ScopedFocusNavigation ownedByIFrame(const HTMLFrameOwnerElement&);
 
 private:
-    explicit FocusNavigationScope(TreeScope*);
-    ContainerNode& rootNode() const;
-    RawPtrWillBeMember<TreeScope> m_rootTreeScope;
+    explicit ScopedFocusNavigation(TreeScope*, const Element*);
+    explicit ScopedFocusNavigation(HTMLSlotElement*, const Element*);
+    RawPtrWillBeMember<ContainerNode> m_rootNode;
+    RawPtrWillBeMember<HTMLSlotElement> m_rootSlot;
+    RawPtrWillBeMember<Element> m_current;
 };
 
-FocusNavigationScope::FocusNavigationScope(TreeScope* treeScope)
-    : m_rootTreeScope(treeScope)
+ScopedFocusNavigation::ScopedFocusNavigation(TreeScope* treeScope, const Element* current)
+    : m_rootNode(treeScope->rootNode())
+    , m_current(const_cast<Element*>(current))
 {
     ASSERT(treeScope);
 }
 
-ContainerNode& FocusNavigationScope::rootNode() const
+ScopedFocusNavigation::ScopedFocusNavigation(HTMLSlotElement* slot, const Element* current)
+    : m_rootSlot(slot)
+    , m_current(const_cast<Element*>(current))
 {
-    return m_rootTreeScope->rootNode();
+    ASSERT(slot);
 }
 
-Element* FocusNavigationScope::firstElement() const
+Element* ScopedFocusNavigation::currentElement() const
 {
-    ContainerNode& root = rootNode();
-    return root.isElementNode() ? &toElement(root) : ElementTraversal::next(root);
+    return m_current;
 }
 
-Element* FocusNavigationScope::lastElement() const
+void ScopedFocusNavigation::currentElement(Element* element)
 {
-    return ElementTraversal::lastWithin(rootNode());
+    m_current = element;
 }
 
-Element* FocusNavigationScope::owner() const
+Element* ScopedFocusNavigation::nextElement()
 {
-    ContainerNode& root = rootNode();
-    if (root.isShadowRoot()) {
-        ShadowRoot& shadowRoot = toShadowRoot(root);
+    if (!m_current)
+        return nullptr;
+    if (m_rootSlot) {
+        m_current = AssignedElementTraversal::next(*m_current);
+    } else {
+        m_current = ElementTraversal::next(*m_current);
+        while (m_current && AssignedElementTraversal::isInAssignedScope(*m_current))
+            m_current = ElementTraversal::next(*m_current);
+    }
+    return m_current;
+}
+
+Element* ScopedFocusNavigation::previousElement()
+{
+    if (!m_current)
+        return nullptr;
+    if (m_rootSlot) {
+        m_current = AssignedElementTraversal::previous(*m_current);
+    } else {
+        m_current = ElementTraversal::previous(*m_current);
+        while (m_current && AssignedElementTraversal::isInAssignedScope(*m_current))
+            m_current = ElementTraversal::previous(*m_current);
+    }
+    return m_current;
+}
+
+Element* ScopedFocusNavigation::firstElement()
+{
+    if (m_rootSlot) {
+        if (!m_rootSlot->getAssignedNodes().isEmpty()) {
+            m_current = toElement(m_rootSlot->getAssignedNodes().first().get());
+        } else {
+            m_current = nullptr;
+        }

[kochi, 2016/03/01 12:55:41]

nit: both if- and else- clasue are one-liner, omit {}.

[yuzuchan, 2016/03/02 09:02:14]

hayato@ told me not to!

[kochi, 2016/03/02 13:26:56]

See https://www.chromium.org/blink/coding-style#TOC-Braces
You can keep the braces, but you can remove.
The rule is that keep it consistent for both if- and else-.

I don't see strong reason not to remove braces here.

As enclosing if-clause has braces around this if-else, you won't
hit so-called "dangling else" issue.
https://en.wikipedia.org/wiki/Dangling_else

[yuzuchan, 2016/03/03 04:12:42]

Done.

+    } else {
+        Element* first = m_rootNode->isElementNode() ? &toElement(*m_rootNode) : ElementTraversal::next(*m_rootNode);
+        while (first && AssignedElementTraversal::isInAssignedScope(*first))
+            first = ElementTraversal::next(*first, m_rootNode);
+        m_current = first;
+    }
+    return m_current;
+}
+
+Element* ScopedFocusNavigation::lastElement()
+{
+    if (m_rootSlot) {
+        if (!m_rootSlot->getAssignedNodes().isEmpty()) {
+            m_current = toElement(m_rootSlot->getAssignedNodes().last().get());
+        } else {
+            m_current = nullptr;
+        }
+    } else {
+        Element* last = ElementTraversal::lastWithin(*m_rootNode);
+        while (last && AssignedElementTraversal::isInAssignedScope(*last))
+            last = ElementTraversal::previous(*last, m_rootNode);
+        m_current = last;
+    }
+    return m_current;
+
+}
+
+Element* ScopedFocusNavigation::owner() const
+{
+    if (m_rootSlot)
+        return m_rootSlot;
+    if (m_rootNode->isShadowRoot()) {
+        ShadowRoot& shadowRoot = toShadowRoot(*m_rootNode);
         return shadowRoot.isYoungest() ? shadowRoot.host() : shadowRoot.shadowInsertionPointOfYoungerShadowRoot();
     }
     // FIXME: Figure out the right thing for OOPI here.
-    if (Frame* frame = root.document().frame())
+    if (Frame* frame = m_rootNode->document().frame())
         return frame->deprecatedLocalOwner();
     return nullptr;
 }
 
-FocusNavigationScope FocusNavigationScope::focusNavigationScopeOf(const Element& element)
+ScopedFocusNavigation ScopedFocusNavigation::focusNavigationScopeOf(const Element& root, const Element* current)
 {
-    return FocusNavigationScope(&element.treeScope());
+    if (AssignedElementTraversal::isInAssignedScope(root))
+        return ScopedFocusNavigation(AssignedElementTraversal::slot(root), current);
+    return ScopedFocusNavigation(&root.treeScope(), current);
 }
 
-FocusNavigationScope FocusNavigationScope::ownedByNonFocusableFocusScopeOwner(Element& element)
+ScopedFocusNavigation ScopedFocusNavigation::ownedByNonFocusableFocusScopeOwner(Element& element)
 {
     if (isShadowHost(element))
-        return FocusNavigationScope::ownedByShadowHost(element);
-    ASSERT(isShadowInsertionPointFocusScopeOwner(element));
-    return FocusNavigationScope::ownedByShadowInsertionPoint(toHTMLShadowElement(element));
+        return ScopedFocusNavigation::ownedByShadowHost(element);
+    if (isShadowInsertionPointFocusScopeOwner(element))
+        return ScopedFocusNavigation::ownedByShadowInsertionPoint(toHTMLShadowElement(element));
+    ASSERT(isHTMLSlotElement(element));
+        return ScopedFocusNavigation::ownedByHTMLSlotElement(toHTMLSlotElement(element));

[kochi, 2016/03/01 12:55:40]

Weird indent?

[yuzuchan, 2016/03/02 09:02:15]

Done.

 }
 
-FocusNavigationScope FocusNavigationScope::ownedByShadowHost(const Element& element)
+ScopedFocusNavigation ScopedFocusNavigation::ownedByShadowHost(const Element& element)
 {
     ASSERT(isShadowHost(element));
-    return FocusNavigationScope(&element.shadow()->youngestShadowRoot());
+    return ScopedFocusNavigation(&element.shadow()->youngestShadowRoot(), nullptr);
 }
 
-FocusNavigationScope FocusNavigationScope::ownedByIFrame(const HTMLFrameOwnerElement& frame)
+ScopedFocusNavigation ScopedFocusNavigation::ownedByIFrame(const HTMLFrameOwnerElement& frame)
 {
     ASSERT(frame.contentFrame());
     ASSERT(frame.contentFrame()->isLocalFrame());
-    return FocusNavigationScope(toLocalFrame(frame.contentFrame())->document());
+    return ScopedFocusNavigation(toLocalFrame(frame.contentFrame())->document(), nullptr);
 }
 
-FocusNavigationScope FocusNavigationScope::ownedByShadowInsertionPoint(HTMLShadowElement& shadowInsertionPoint)
+ScopedFocusNavigation ScopedFocusNavigation::ownedByShadowInsertionPoint(HTMLShadowElement& shadowInsertionPoint)
 {
     ASSERT(isShadowInsertionPointFocusScopeOwner(shadowInsertionPoint));
-    return FocusNavigationScope(shadowInsertionPoint.olderShadowRoot());
+    return ScopedFocusNavigation(shadowInsertionPoint.olderShadowRoot(), nullptr);
+}
+
+ScopedFocusNavigation ScopedFocusNavigation::ownedByHTMLSlotElement(HTMLSlotElement& element)
+{
+    return ScopedFocusNavigation(&element, nullptr);
 }
 
 inline void dispatchBlurEvent(const Document& document, Element& focusedElement)
 {
     focusedElement.dispatchBlurEvent(nullptr, WebFocusTypePage);
     if (focusedElement == document.focusedElement()) {
         focusedElement.dispatchFocusOutEvent(EventTypeNames::focusout, nullptr);
         if (focusedElement == document.focusedElement())
             focusedElement.dispatchFocusOutEvent(EventTypeNames::DOMFocusOut, nullptr);
     }
@@ skipping 62 matching lines @@
     return isShadowHostWithoutCustomFocusLogic(element) && !element.isKeyboardFocusable();
 }
 
 inline bool isKeyboardFocusableShadowHost(const Element& element)
 {
     return isShadowHostWithoutCustomFocusLogic(element) && element.isKeyboardFocusable();
 }
 
 inline bool isNonFocusableFocusScopeOwner(Element& element)
 {
-    return isNonKeyboardFocusableShadowHost(element) || isShadowInsertionPointFocusScopeOwner(element);
+    return isNonKeyboardFocusableShadowHost(element) || isShadowInsertionPointFocusScopeOwner(element) || isHTMLSlotElement(element);
 }
 
 inline bool isShadowHostDelegatesFocus(const Element& element)
 {
     return element.authorShadowRoot() && element.authorShadowRoot()->delegatesFocus();
 }
 
 inline int adjustedTabIndex(Element& element)
 {
     return isNonFocusableFocusScopeOwner(element) ? 0 : element.tabIndex();
 }
 
 inline bool shouldVisit(Element& element)
 {
     return element.isKeyboardFocusable() || isNonFocusableFocusScopeOwner(element);
 }
 
-Element* findElementWithExactTabIndex(Element* start, int tabIndex, WebFocusType type)
+Element* findElementWithExactTabIndex(ScopedFocusNavigation& scope, int tabIndex, WebFocusType type)
 {
     // Search is inclusive of start
-    for (Element* element = start; element; element = type == WebFocusTypeForward ? ElementTraversal::next(*element) : ElementTraversal::previous(*element)) {
-        if (shouldVisit(*element) && adjustedTabIndex(*element) == tabIndex)
-            return element;
+    Element* current;
+    for (; scope.currentElement(); type == WebFocusTypeForward ? scope.nextElement() : scope.previousElement()) {
+        current = scope.currentElement();

[kochi, 2016/03/01 12:55:41]

nit: You can remove line 342 and write this line as Element* current =
scope.currentElement();

[yuzuchan, 2016/03/02 09:02:15]

Done.

+        if (shouldVisit(*current) && adjustedTabIndex(*current) == tabIndex)
+            return current;
     }
     return nullptr;
 }
 
-Element* nextElementWithGreaterTabIndex(Element* start, int tabIndex)
+Element* nextElementWithGreaterTabIndex(ScopedFocusNavigation& scope, int tabIndex)
 {
     // Search is inclusive of start
     int winningTabIndex = std::numeric_limits<short>::max() + 1;
     Element* winner = nullptr;
-    for (Element& element : ElementTraversal::startsAt(start)) {
-        int currentTabIndex = adjustedTabIndex(element);
-        if (shouldVisit(element) && currentTabIndex > tabIndex && currentTabIndex < winningTabIndex) {
-            winner = &element;
+    Element* current;
+    for (; scope.currentElement(); scope.nextElement()) {
+        current = scope.currentElement();

[kochi, 2016/03/01 12:55:41]

nit: You can remove line 356 and write this line as Element* current =
scope.currentElement();

[yuzuchan, 2016/03/02 09:02:15]

Done.

+        int currentTabIndex = adjustedTabIndex(*current);
+        if (shouldVisit(*current) && currentTabIndex > tabIndex && currentTabIndex < winningTabIndex) {
+            winner = current;
             winningTabIndex = currentTabIndex;
         }
     }
     return winner;
 }
 
-Element* previousElementWithLowerTabIndex(Element* start, int tabIndex)
+Element* previousElementWithLowerTabIndex(ScopedFocusNavigation& scope, int tabIndex)
 {
     // Search is inclusive of start
     int winningTabIndex = 0;
     Element* winner = nullptr;
-    for (Element* element = start; element; element = ElementTraversal::previous(*element)) {
-        int currentTabIndex = adjustedTabIndex(*element);
-        if (shouldVisit(*element) && currentTabIndex < tabIndex && currentTabIndex > winningTabIndex) {
-            winner = element;
+    Element* current;
+    for (; scope.currentElement(); scope.previousElement()) {
+        current = scope.currentElement();

[kochi, 2016/03/01 12:55:41]

nit: You can remove line 373 and write this line as Element* current =
scope.currentElement();

[yuzuchan, 2016/03/02 09:02:15]

Done.

+        int currentTabIndex = adjustedTabIndex(*current);
+        if (shouldVisit(*current) && currentTabIndex < tabIndex && currentTabIndex > winningTabIndex) {
+            winner = current;
             winningTabIndex = currentTabIndex;
         }
     }
     return winner;
 }
 
-Element* nextFocusableElement(const FocusNavigationScope& scope, Element* start)
+Element* nextFocusableElement(ScopedFocusNavigation& scope)
 {
-    if (start) {
-        int tabIndex = adjustedTabIndex(*start);
+    Element* current = scope.currentElement();
+    if (current) {
+        int tabIndex = adjustedTabIndex(*current);
         // If an element is excluded from the normal tabbing cycle, the next focusable element is determined by tree order
         if (tabIndex < 0) {
-            for (Element& element : ElementTraversal::startsAfter(*start)) {
-                if (shouldVisit(element) && adjustedTabIndex(element) >= 0)
-                    return &element;
+            for (scope.nextElement(); scope.currentElement(); scope.nextElement()) {
+                current = scope.currentElement();
+                if (shouldVisit(*current) && adjustedTabIndex(*current) >= 0)
+                    return current;
             }
         } else {
             // First try to find an element with the same tabindex as start that comes after start in the scope.
-            if (Element* winner = findElementWithExactTabIndex(ElementTraversal::next(*start), tabIndex, WebFocusTypeForward))
+            scope.nextElement();
+            if (Element* winner = findElementWithExactTabIndex(scope, tabIndex, WebFocusTypeForward))
                 return winner;
         }
         if (!tabIndex) {
             // We've reached the last element in the document with a tabindex of 0. This is the end of the tabbing order.
             return nullptr;
         }
     }
 
     // Look for the first element in the scope that:
     // 1) has the lowest tabindex that is higher than start's tabindex (or 0, if start is null), and
     // 2) comes first in the scope, if there's a tie.
-    if (Element* winner = nextElementWithGreaterTabIndex(scope.firstElement(), start ? adjustedTabIndex(*start) : 0))
+    scope.currentElement(scope.firstElement());

[kochi, 2016/03/01 12:55:41]

Doesn't scope.firstElement() set scope's m_current internally?

I'd suggest rename the method to scope.moveToFirst(), or
make firstElement() as const method and do not update m_current internally.

In Blink's naming convention, noun-like method is usually just something,
without side effects
and verb-like method does something and may or may not return value.
.firstElement() violates the convention and thus it is confusing.

[yuzuchan, 2016/03/02 09:02:15]

Done.

+    if (Element* winner = nextElementWithGreaterTabIndex(scope, current ? adjustedTabIndex(*current) : 0)) {
         return winner;
+    }
 
     // There are no elements with a tabindex greater than start's tabindex,
     // so find the first element with a tabindex of 0.
-    return findElementWithExactTabIndex(scope.firstElement(), 0, WebFocusTypeForward);
+    scope.currentElement(scope.firstElement());

[kochi, 2016/03/01 12:55:41]

Ditto

[yuzuchan, 2016/03/02 09:02:15]

Done.

+    return findElementWithExactTabIndex(scope, 0, WebFocusTypeForward);
 }
 
-Element* previousFocusableElement(const FocusNavigationScope& scope, Element* start)
+Element* previousFocusableElement(ScopedFocusNavigation& scope)
 {
-    Element* lastElement = scope.lastElement();
-
     // First try to find the last element in the scope that comes before start and has the same tabindex as start.
     // If start is null, find the last element in the scope with a tabindex of 0.
-    Element* startElement;
     int startTabIndex;
-    if (start) {
-        startElement = ElementTraversal::previous(*start);
-        startTabIndex = adjustedTabIndex(*start);
+    Element* current = scope.currentElement();
+    if (current) {
+        scope.previousElement();
+        startTabIndex = adjustedTabIndex(*current);
     } else {
-        startElement = lastElement;
+        scope.lastElement();
         startTabIndex = 0;
     }
 
     // However, if an element is excluded from the normal tabbing cycle, the previous focusable element is determined by tree order
     if (startTabIndex < 0) {
-        for (Element* element = startElement; element; element = ElementTraversal::previous(*element)) {
-            if (shouldVisit(*element) && adjustedTabIndex(*element) >= 0)
-                return element;
+        for (scope.previousElement(); scope.currentElement(); scope.previousElement()) {

[kochi, 2016/03/01 12:55:41]

If the return value of the first statement (first scope.previousElement()) isn't
used or assigned to any variable,
please move it out of for ().

[yuzuchan, 2016/03/02 09:02:15]

Done.

+            current = scope.currentElement();
+            if (shouldVisit(*current) && adjustedTabIndex(*current) >= 0)
+                return current;
         }
     } else {
-        if (Element* winner = findElementWithExactTabIndex(startElement, startTabIndex, WebFocusTypeBackward))
+        if (Element* winner = findElementWithExactTabIndex(scope, startTabIndex, WebFocusTypeBackward))
             return winner;
     }
 
+

[kochi, 2016/03/01 12:55:41]

nit: an unnecessary empty line sneaked in.

[yuzuchan, 2016/03/02 09:02:14]

Done.

     // There are no elements before start with the same tabindex as start, so look for an element that:
     // 1) has the highest non-zero tabindex (that is less than start's tabindex), and
     // 2) comes last in the scope, if there's a tie.
-    startTabIndex = (start && startTabIndex) ? startTabIndex : std::numeric_limits<short>::max();
-    return previousElementWithLowerTabIndex(lastElement, startTabIndex);
+    startTabIndex = (current && startTabIndex) ? startTabIndex : std::numeric_limits<short>::max();
+    scope.currentElement(scope.lastElement());
+
+    return previousElementWithLowerTabIndex(scope, startTabIndex);
 }
 
 // Searches through the given tree scope, starting from start element, for the next/previous
 // selectable element that comes after/before start element.
 // The order followed is as specified in the HTML spec[1], which is elements with tab indexes
 // first (from lowest to highest), and then elements without tab indexes (in document order).
 // The search algorithm also conforms the Shadow DOM spec[2], which inserts sequence in a shadow
 // tree into its host.
 //
 // @param start The element from which to start searching. The element after this will be focused.
 //        May be null.
 // @return The focus element that comes after/before start element.
 //
 // [1] https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus-navigation
 // [2] https://w3c.github.io/webcomponents/spec/shadow/#focus-navigation
-inline Element* findFocusableElementInternal(WebFocusType type, const FocusNavigationScope& scope, Element* element)
+inline Element* findFocusableElementInternal(WebFocusType type, ScopedFocusNavigation& scope)
 {
-    Element* found = (type == WebFocusTypeForward) ? nextFocusableElement(scope, element) : previousFocusableElement(scope, element);
+    Element* found = (type == WebFocusTypeForward) ? nextFocusableElement(scope) : previousFocusableElement(scope);
     return found;
 }
 
-Element* findFocusableElementRecursivelyForward(const FocusNavigationScope& scope, Element* start)
+Element* findFocusableElementRecursivelyForward(ScopedFocusNavigation& scope)
 {
     // Starting element is exclusive.
-    Element* found = findFocusableElementInternal(WebFocusTypeForward, scope, start);
+    Element* found = findFocusableElementInternal(WebFocusTypeForward, scope);
     while (found) {
         if (isShadowHostDelegatesFocus(*found)) {
             // If tabindex is positive, find focusable element inside its shadow tree.
             if (found->tabIndex() >= 0 && isShadowHostWithoutCustomFocusLogic(*found)) {
-                FocusNavigationScope innerScope = FocusNavigationScope::ownedByShadowHost(*found);
-                if (Element* foundInInnerFocusScope = findFocusableElementRecursivelyForward(innerScope, nullptr))
+                ScopedFocusNavigation innerScope = ScopedFocusNavigation::ownedByShadowHost(*found);
+                if (Element* foundInInnerFocusScope = findFocusableElementRecursivelyForward(innerScope))
                     return foundInInnerFocusScope;
             }
             // Skip to the next element in the same scope.
-            found = findFocusableElementInternal(WebFocusTypeForward, scope, found);
+            found = findFocusableElementInternal(WebFocusTypeForward, scope);
             continue;
         }
         if (!isNonFocusableFocusScopeOwner(*found))
             return found;
 
-        // Now |found| is on a non focusable scope owner (either shadow host or <shadow>)
+        // Now |found| is on a non focusable scope owner (either shadow host or <shadow> or slot)
         // Find inside the inward scope and return it if found. Otherwise continue searching in the same
         // scope.
-        FocusNavigationScope innerScope = FocusNavigationScope::ownedByNonFocusableFocusScopeOwner(*found);
-        if (Element* foundInInnerFocusScope = findFocusableElementRecursivelyForward(innerScope, nullptr))
+        ScopedFocusNavigation innerScope = ScopedFocusNavigation::ownedByNonFocusableFocusScopeOwner(*found);
+        if (Element* foundInInnerFocusScope = findFocusableElementRecursivelyForward(innerScope))
             return foundInInnerFocusScope;
 
-        found = findFocusableElementInternal(WebFocusTypeForward, scope, found);
+        scope.currentElement(found);
+        found = findFocusableElementInternal(WebFocusTypeForward, scope);
     }
     return nullptr;
 }
 
-Element* findFocusableElementRecursivelyBackward(const FocusNavigationScope& scope, Element* start)
+Element* findFocusableElementRecursivelyBackward(ScopedFocusNavigation& scope)
 {
     // Starting element is exclusive.
-    Element* found = findFocusableElementInternal(WebFocusTypeBackward, scope, start);
+    Element* found = findFocusableElementInternal(WebFocusTypeBackward, scope);
+
     while (found) {
         // Now |found| is on a focusable shadow host.
         // Find inside shadow backwards. If any focusable element is found, return it, otherwise return
         // the host itself.
         if (isKeyboardFocusableShadowHost(*found)) {
-            FocusNavigationScope innerScope = FocusNavigationScope::ownedByShadowHost(*found);
-            Element* foundInInnerFocusScope = findFocusableElementRecursivelyBackward(innerScope, nullptr);
+            ScopedFocusNavigation innerScope = ScopedFocusNavigation::ownedByShadowHost(*found);
+            Element* foundInInnerFocusScope = findFocusableElementRecursivelyBackward(innerScope);
             if (foundInInnerFocusScope)
                 return foundInInnerFocusScope;
             if (isShadowHostDelegatesFocus(*found)) {
-                found = findFocusableElementInternal(WebFocusTypeBackward, scope, found);
+                found = findFocusableElementInternal(WebFocusTypeBackward, scope);
                 continue;
             }
             return found;
         }
 
         // If delegatesFocus is true and tabindex is negative, skip the whole shadow tree under the
         // shadow host.
         if (isShadowHostDelegatesFocus(*found) && found->tabIndex() < 0) {
-            found = findFocusableElementInternal(WebFocusTypeBackward, scope, found);
+            found = findFocusableElementInternal(WebFocusTypeBackward, scope);
             continue;
         }
 
-        // Now |found| is on a non focusable scope owner (either shadow host or <shadow>).
-        // Find focusable element in descendant scope. If not found, find next focusable element within the
+        // Now |found| is on a non focusable scope owner (either shadow host or <shadow> or slot).
+        // Find focusable node in descendant scope. If not found, find next focusable node within the

[kochi, 2016/03/01 12:55:41]

Do not revert back from element to node.
A node is not focusable, an element is focusable.

[yuzuchan, 2016/03/03 04:12:42]

Done.

         // current scope.
         if (isNonFocusableFocusScopeOwner(*found)) {
-            FocusNavigationScope innerScope = FocusNavigationScope::ownedByNonFocusableFocusScopeOwner(*found);
-            Element* foundInInnerFocusScope = findFocusableElementRecursivelyBackward(innerScope, nullptr);
+            ScopedFocusNavigation innerScope = ScopedFocusNavigation::ownedByNonFocusableFocusScopeOwner(*found);
+            Element* foundInInnerFocusScope = findFocusableElementRecursivelyBackward(innerScope);
+
+
             if (foundInInnerFocusScope)
                 return foundInInnerFocusScope;
-            found = findFocusableElementInternal(WebFocusTypeBackward, scope, found);
+            found = findFocusableElementInternal(WebFocusTypeBackward, scope);
             continue;
         }
         if (!isShadowHostDelegatesFocus(*found))
             return found;
-        found = findFocusableElementInternal(WebFocusTypeBackward, scope, found);
+
+        scope.currentElement(found);
+        found = findFocusableElementInternal(WebFocusTypeBackward, scope);
     }
     return nullptr;
 }
 
-Element* findFocusableElementRecursively(WebFocusType type, const FocusNavigationScope& scope, Element* start)
+Element* findFocusableElementRecursively(WebFocusType type, ScopedFocusNavigation& scope)
 {
     return (type == WebFocusTypeForward) ?
-        findFocusableElementRecursivelyForward(scope, start) :
-        findFocusableElementRecursivelyBackward(scope, start);
+        findFocusableElementRecursivelyForward(scope) :
+        findFocusableElementRecursivelyBackward(scope);
 }
 
 Element* findFocusableElementDescendingDownIntoFrameDocument(WebFocusType type, Element* element)
 {
     // The element we found might be a HTMLFrameOwnerElement, so descend down the tree until we find either:
     // 1) a focusable element, or
     // 2) the deepest-nested HTMLFrameOwnerElement.
     while (element && element->isFrameOwnerElement()) {
         HTMLFrameOwnerElement& owner = toHTMLFrameOwnerElement(*element);
         if (!owner.contentFrame() || !owner.contentFrame()->isLocalFrame())
             break;
         toLocalFrame(owner.contentFrame())->document()->updateLayoutIgnorePendingStylesheets();
-        Element* foundElement = findFocusableElementRecursively(type, FocusNavigationScope::ownedByIFrame(owner), nullptr);
+        ScopedFocusNavigation scope = ScopedFocusNavigation::ownedByIFrame(owner);
+        Element* foundElement = findFocusableElementRecursively(type, scope);
         if (!foundElement)
             break;
         ASSERT(element != foundElement);
         element = foundElement;
     }
     return element;
 }
 
-Element* findFocusableElementAcrossFocusScopesForward(const FocusNavigationScope& scope, Element* current)
+Element* findFocusableElementAcrossFocusScopesForward(ScopedFocusNavigation& scope)
 {
+    Element* current = scope.currentElement();
     ASSERT(!current || !isNonFocusableShadowHost(*current));
     Element* found;
     if (current && isShadowHostWithoutCustomFocusLogic(*current)) {
-        FocusNavigationScope innerScope = FocusNavigationScope::ownedByShadowHost(*current);
-        Element* foundInInnerFocusScope = findFocusableElementRecursivelyForward(innerScope, nullptr);
-        found = foundInInnerFocusScope ? foundInInnerFocusScope : findFocusableElementRecursivelyForward(scope, current);
+        ScopedFocusNavigation innerScope = ScopedFocusNavigation::ownedByShadowHost(*current);
+        Element* foundInInnerFocusScope = findFocusableElementRecursivelyForward(innerScope);
+        found = foundInInnerFocusScope ? foundInInnerFocusScope : findFocusableElementRecursivelyForward(scope);
     } else {
-        found = findFocusableElementRecursivelyForward(scope, current);
+        found = findFocusableElementRecursivelyForward(scope);
     }
 
     // If there's no focusable element to advance to, move up the focus scopes until we find one.
-    FocusNavigationScope currentScope = scope;
+    ScopedFocusNavigation currentScope = scope;
     while (!found) {
         Element* owner = currentScope.owner();
         if (!owner)
             break;
-        currentScope = FocusNavigationScope::focusNavigationScopeOf(*owner);
-        found = findFocusableElementRecursivelyForward(currentScope, owner);
+        currentScope = ScopedFocusNavigation::focusNavigationScopeOf(*owner, owner);
+        found = findFocusableElementRecursivelyForward(currentScope);
     }
     return findFocusableElementDescendingDownIntoFrameDocument(WebFocusTypeForward, found);
 }
 
-Element* findFocusableElementAcrossFocusScopesBackward(const FocusNavigationScope& scope, Element* current)
+Element* findFocusableElementAcrossFocusScopesBackward(ScopedFocusNavigation& scope)
 {
-    ASSERT(!current || !isNonFocusableShadowHost(*current));
-    Element* found = findFocusableElementRecursivelyBackward(scope, current);
+    ASSERT(!scope.currentElement() || !isNonFocusableShadowHost(*scope.currentElement()));
+    Element* found = findFocusableElementRecursivelyBackward(scope);
 
     // If there's no focusable element to advance to, move up the focus scopes until we find one.
-    FocusNavigationScope currentScope = scope;
+    ScopedFocusNavigation currentScope = scope;
     while (!found) {
         Element* owner = currentScope.owner();
         if (!owner)
             break;
-        currentScope = FocusNavigationScope::focusNavigationScopeOf(*owner);
+        currentScope = ScopedFocusNavigation::focusNavigationScopeOf(*owner, owner);
         if (isKeyboardFocusableShadowHost(*owner) && !isShadowHostDelegatesFocus(*owner)) {
             found = owner;
             break;
         }
-        found = findFocusableElementRecursivelyBackward(currentScope, owner);
+        found = findFocusableElementRecursivelyBackward(currentScope);
     }
     return findFocusableElementDescendingDownIntoFrameDocument(WebFocusTypeBackward, found);
 }
 
-Element* findFocusableElementAcrossFocusScopes(WebFocusType type, const FocusNavigationScope& scope, Element* current)
+Element* findFocusableElementAcrossFocusScopes(WebFocusType type, ScopedFocusNavigation& scope)
 {
     return (type == WebFocusTypeForward) ?
-        findFocusableElementAcrossFocusScopesForward(scope, current) :
-        findFocusableElementAcrossFocusScopesBackward(scope, current);
+        findFocusableElementAcrossFocusScopesForward(scope) :
+        findFocusableElementAcrossFocusScopesBackward(scope);
 }
 
 inline Element* adjustToElement(Node* node, WebFocusType type)
 {
     ASSERT(type == WebFocusTypeForward || type == WebFocusTypeBackward);
     if (!node)
         return nullptr;
     if (node->isElementNode())
         return toElement(node);
     // The returned element is used as an *exclusive* start element. Thus, we should return the result of ElementTraversal::previous(*node),
     // instead of ElementTraversal::next(*node), if type == WebFocusTypeForward, and vice-versa.
     // The caller will call ElementTraversal::{next/previous} for the returned value and get the {next|previous} element of the |node|.
+
+
+    // change to my traversal????

[kochi, 2016/03/01 12:55:41]

Could you resolve this?    :)

[yuzuchan, 2016/03/02 09:02:15]

Done.

     return (type == WebFocusTypeForward) ? ElementTraversal::previous(*node) : ElementTraversal::next(*node);
 }
 
 } // anonymous namespace
 
 FocusController::FocusController(Page* page)
     : m_page(page)
     , m_isActive(false)
     , m_isFocused(false)
     , m_isChangingFocusedFrame(false)
@@ skipping 194 matching lines @@
     if (!current)
         current = document->sequentialFocusNavigationStartingPoint(type);
 
     // FIXME: Not quite correct when it comes to focus transitions leaving/entering the WebView itself
     bool caretBrowsing = frame->settings() && frame->settings()->caretBrowsingEnabled();
 
     if (caretBrowsing && !current)
         current = adjustToElement(frame->selection().start().anchorNode(), type);
 
     document->updateLayoutIgnorePendingStylesheets();
-
-    RefPtrWillBeRawPtr<Element> element = findFocusableElementAcrossFocusScopes(type, FocusNavigationScope::focusNavigationScopeOf(current ? *current : *document->documentElement()), current);
+    ScopedFocusNavigation scope = ScopedFocusNavigation::focusNavigationScopeOf(current ? *current : *document->documentElement(), current);
+    RefPtrWillBeRawPtr<Element> element = findFocusableElementAcrossFocusScopes(type, scope);
 
     if (!element) {
         // If there's a RemoteFrame on the ancestor chain, we need to continue
         // searching for focusable elements there.
         if (frame->localFrameRoot() != frame->tree().top()) {
             document->clearFocusedElement();
             document->setSequentialFocusNavigationStartingPoint(nullptr);
             toRemoteFrame(frame->localFrameRoot()->tree().parent())->advanceFocus(type, frame->localFrameRoot());
             return true;
         }
 
         // We didn't find an element to focus, so we should try to pass focus to Chrome.
         if (!initialFocus && m_page->chromeClient().canTakeFocus(type)) {
             document->clearFocusedElement();
             document->setSequentialFocusNavigationStartingPoint(nullptr);
             setFocusedFrame(nullptr);
             m_page->chromeClient().takeFocus(type);
             return true;
         }
 
         // Chrome doesn't want focus, so we should wrap focus.
-        element = findFocusableElementRecursively(type, FocusNavigationScope::focusNavigationScopeOf(*toLocalFrame(m_page->mainFrame())->document()->documentElement()), nullptr);
+        ScopedFocusNavigation scope = ScopedFocusNavigation::focusNavigationScopeOf(*toLocalFrame(m_page->mainFrame())->document()->documentElement(), nullptr);
+        element = findFocusableElementRecursively(type, scope);
         element = findFocusableElementDescendingDownIntoFrameDocument(type, element.get());
 
         if (!element)
             return false;
     }
 
     ASSERT(element);
 
     if (element == document->focusedElement()) {
         // Focus wrapped around to the same element.
@@ skipping 39 matching lines @@
     }
 
     element->focus(FocusParams(SelectionBehaviorOnFocus::Reset, type, sourceCapabilities));
     return true;
 }
 
 Element* FocusController::findFocusableElement(WebFocusType type, Element& element)
 {
     // FIXME: No spacial navigation code yet.
     ASSERT(type == WebFocusTypeForward || type == WebFocusTypeBackward);
-    return findFocusableElementAcrossFocusScopes(type, FocusNavigationScope::focusNavigationScopeOf(element), &element);
+    ScopedFocusNavigation scope = ScopedFocusNavigation::focusNavigationScopeOf(element, &element);
+    return findFocusableElementAcrossFocusScopes(type, scope);
 }
 
 Element* FocusController::findFocusableElementInShadowHost(const Element& shadowHost)
 {
     ASSERT(shadowHost.authorShadowRoot());
-    return findFocusableElementAcrossFocusScopes(WebFocusTypeForward, FocusNavigationScope::ownedByShadowHost(shadowHost), nullptr);
+    ScopedFocusNavigation scope = ScopedFocusNavigation::ownedByShadowHost(shadowHost);
+    return findFocusableElementAcrossFocusScopes(WebFocusTypeForward, scope);
 }
 
 static bool relinquishesEditingFocus(const Element& element)
 {
     ASSERT(element.hasEditableStyle());
     return element.document().frame() && element.rootEditableElement();
 }
 
 static void clearSelectionIfNeeded(LocalFrame* oldFocusedFrame, LocalFrame* newFocusedFrame, Element* newFocusedElement)
 {
@@ skipping 282 matching lines @@
     return consumed;
 }
 
 DEFINE_TRACE(FocusController)
 {
     visitor->trace(m_page);
     visitor->trace(m_focusedFrame);
 }
 
 } // namespace blink