[wasm] Refactor WASM test usage of TestingModule.

[wasm] Refactor WASM test usage of TestingModule.

This cleans up and makes the tests easier to write and understand.
Also prepares for adding the WASM interpreter which needs a
different initialization sequence in tests.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/e96a54f7b5fd7ad8a2306dc2d509a3bdc6aa8a56
Cr-Commit-Position: refs/heads/master@{#34123}

[ahaas, 2016-02-18 14:17:46]

https://codereview.chromium.org/1707403002/diff/20001/test/cctest/wasm/test-r...
File test/cctest/wasm/test-run-wasm.cc (right):

https://codereview.chromium.org/1707403002/diff/20001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm.cc:87: TestingModule module;
Why do you declare the TestingModule in the test? Couldn't it be a field of the
WasmRunner?

https://codereview.chromium.org/1707403002/diff/20001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm.cc:2663: BUILD(t1,
WASM_I32_ADD(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
Why do you pass two parameters here? Just say WASM_I32_ADD(WASM_GET_LOCAL(0),
WASM_GET_LOCAL(0))

https://codereview.chromium.org/1707403002/diff/20001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm.cc:2673: WASM_CALL_FUNCTION(t1.function_index_,
WASM_GET_LOCAL(1),
Why don't you use WASM_GET_LOCAL(local) here?

[titzer, 2016-02-18 14:59:37]

https://codereview.chromium.org/1707403002/diff/20001/test/cctest/wasm/test-r...
File test/cctest/wasm/test-run-wasm.cc (right):

https://codereview.chromium.org/1707403002/diff/20001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm.cc:87: TestingModule module;
On 2016/02/18 14:17:46, ahaas wrote:
> Why do you declare the TestingModule in the test? Couldn't it be a field of
the
> WasmRunner?

Many tests don't use need module, and there is already a lot of entanglement in
the wasm runner :(

https://codereview.chromium.org/1707403002/diff/20001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm.cc:2663: BUILD(t1,
WASM_I32_ADD(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
On 2016/02/18 14:17:46, ahaas wrote:
> Why do you pass two parameters here? Just say WASM_I32_ADD(WASM_GET_LOCAL(0),
> WASM_GET_LOCAL(0))

Checking two is better than checking one :-)

https://codereview.chromium.org/1707403002/diff/20001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm.cc:2673: WASM_CALL_FUNCTION(t1.function_index_,
WASM_GET_LOCAL(1),
On 2016/02/18 14:17:46, ahaas wrote:
> Why don't you use WASM_GET_LOCAL(local) here?

Good catch. Done.

[ahaas, 2016-02-18 15:02:48]

lgtm

https://codereview.chromium.org/1707403002/diff/20001/test/cctest/wasm/test-r...
File test/cctest/wasm/test-run-wasm.cc (right):

https://codereview.chromium.org/1707403002/diff/20001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm.cc:87: TestingModule module;
On 2016/02/18 at 14:59:36, titzer wrote:
> On 2016/02/18 14:17:46, ahaas wrote:
> > Why do you declare the TestingModule in the test? Couldn't it be a field of
the
> > WasmRunner?
> 
> Many tests don't use need module, and there is already a lot of entanglement
in the wasm runner :(

I don't agree, but that's only a personal preference anyways.

[titzer, 2016-02-18 15:34:31]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-02-18 15:34:32]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1707403002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-02-18 15:34:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707403002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707403002/100001

[commit-bot: I haz the power, 2016-02-18 15:58:06]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-18 15:58:35]

Description was changed from

==========
[wasm] Refactor WASM test usage of TestingModule.

This cleans up and makes the tests easier to write and understand.
Also prepares for adding the WASM interpreter which needs a
different initialization sequence in tests.

R=ahaas@chromium.org
BUG=
==========

to

==========
[wasm] Refactor WASM test usage of TestingModule.

This cleans up and makes the tests easier to write and understand.
Also prepares for adding the WASM interpreter which needs a
different initialization sequence in tests.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/e96a54f7b5fd7ad8a2306dc2d509a3bdc6aa8a56
Cr-Commit-Position: refs/heads/master@{#34123}
==========

[commit-bot: I haz the power, 2016-02-18 15:58:36]

Patchset 6 (id:??) landed as
https://crrev.com/e96a54f7b5fd7ad8a2306dc2d509a3bdc6aa8a56
Cr-Commit-Position: refs/heads/master@{#34123}