Created multi-process-friendly PowerMonitor interface.

content/gpu/gpu_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
 
 #include "base/debug/trace_event.h"
 #include "base/lazy_instance.h"
 #include "base/message_loop.h"
 #include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/threading/platform_thread.h"
 #include "build/build_config.h"
 #include "content/child/child_process.h"
 #include "content/common/gpu/gpu_config.h"
 #include "content/common/gpu/gpu_messages.h"
+#include "content/common/power_monitor_client.h"
 #include "content/common/sandbox_linux.h"
 #include "content/gpu/gpu_child_thread.h"
 #include "content/gpu/gpu_process.h"
 #include "content/gpu/gpu_watchdog_thread.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/main_function_params.h"
 #include "crypto/hmac.h"
 #include "gpu/config/gpu_info_collector.h"
 #include "ui/gl/gl_implementation.h"
@@ skipping 130 matching lines @@
 #endif
 
   bool delayed_watchdog_enable = false;
 
 #if defined(OS_CHROMEOS)
   // Don't start watchdog immediately, to allow developers to switch to VT2 on
   // startup.
   delayed_watchdog_enable = true;
 #endif
 
+  PowerMonitorClient power_monitor;

[Ken Russell (switch to Gerrit), 2013/06/24 22:54:38]

I don't think this function should stack-allocate a PowerMonitorClient instance.
If necessary, the PowerMonitorClient can be fetched and initialized here for use
elsewhere, but the PowerMonitorClient singleton should manage its own lifetime.
(If necessary, a Shutdown() method can be added to PowerMonitorClient to eagerly
terminate it and delete the singleton.)

[bajones, 2013/06/25 18:33:34]

While my gut reaction is to agree with you, this is actually a well established
pattern for use of the PowerMonitor. (See
https://code.google.com/p/chromium/codesearch#search/&q=base::PowerMonitor%20...).

   scoped_refptr<GpuWatchdogThread> watchdog_thread;
 
   // Start the GPU watchdog only after anything that is expected to be time
   // consuming has completed, otherwise the process is liable to be aborted.
   if (enable_watchdog && !delayed_watchdog_enable) {
     watchdog_thread = new GpuWatchdogThread(kGpuTimeout);
     watchdog_thread->Start();
   }
 
   gpu::GPUInfo gpu_info;
@@ skipping 244 matching lines @@
     return true;
   }
 
   return false;
 }
 #endif  // defined(OS_WIN)
 
 }  // namespace.
 
 }  // namespace content