Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 17074008: added back support to speech when ask_user=false (Closed)

Created:
7 years, 6 months ago by no longer working on chromium
Modified:
7 years, 6 months ago
Reviewers:
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

added back support to speech when ask_user=false. We should use the default device for the deprecated API. TBR=henrika@chromium.org BUG=252848 TEST= <script> recognition = new webkitSpeechRecognition(); recognition.start(); </script> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208020

Patch Set 1 : #

Patch Set 2 : rebased #

Patch Set 3 : added a TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M content/browser/speech/speech_recognition_manager_impl.cc View 1 2 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
no longer working on chromium
7 years, 6 months ago (2013-06-22 13:40:28 UTC) #1
Message was sent while issue was closed.
Committed patchset #3 manually as r208020 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698