Chromium Code Reviews
Description[Android] Change "handling" of unhandled key events.
When we receive an IME Key Down event in Android, we forward it to
WebKit for processing as RawKeyDown, followed by a WebInputEvent::Char
if it had a character associated with it.
When typing into a text field or textarea, if the RawKeyDown triggers
an editing event it will go unhandled by WebKit, and it's the subsequent
Char event that WebKit handles. The unhandled RawKeyDown is propogated
back down to the Browser and out to the embedder. In the Android WebView
where we then propogate the unhandled event to the WebView embedder.
However - as the Char event is going to be handled by the textarea
later, informing the embedder that the KeyDown wasn't handled isn't
what it expects and we shouldn't do so. We should only propogate an
unhandled Char event to the WebView embedder.
This CL fixes this by using the NativeWebKeyboardEvent.skip_in_browser
flag to prevent browser side handling of the RawKeyDown. It also
fixes a bug in the propogation of the synthetic Char event.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208659
Patch Set 1 #Patch Set 2 : ps2 #Messages
Total messages: 6 (0 generated)
|