Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 17074005: [Android] Change "handling" of unhandled key events. (Closed)

Created:
7 years, 6 months ago by benm (inactive)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Change "handling" of unhandled key events. When we receive an IME Key Down event in Android, we forward it to WebKit for processing as RawKeyDown, followed by a WebInputEvent::Char if it had a character associated with it. When typing into a text field or textarea, if the RawKeyDown triggers an editing event it will go unhandled by WebKit, and it's the subsequent Char event that WebKit handles. The unhandled RawKeyDown is propogated back down to the Browser and out to the embedder. In the Android WebView where we then propogate the unhandled event to the WebView embedder. However - as the Char event is going to be handled by the textarea later, informing the embedder that the KeyDown wasn't handled isn't what it expects and we shouldn't do so. We should only propogate an unhandled Char event to the WebView embedder. This CL fixes this by using the NativeWebKeyboardEvent.skip_in_browser flag to prevent browser side handling of the RawKeyDown. It also fixes a bug in the propogation of the synthetic Char event. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208659

Patch Set 1 #

Patch Set 2 : ps2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M content/browser/renderer_host/ime_adapter_android.cc View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
aurimas (slooooooooow)
+yusufo who worked on key event handling.
7 years, 6 months ago (2013-06-21 17:01:45 UTC) #1
Yusuf
On 2013/06/21 17:01:45, aurimas wrote: > +yusufo who worked on key event handling. lgtm
7 years, 6 months ago (2013-06-24 23:26:56 UTC) #2
benm (inactive)
+sievers for OWNERS
7 years, 6 months ago (2013-06-25 00:31:11 UTC) #3
no sievers
lgtm
7 years, 6 months ago (2013-06-25 19:16:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/17074005/4001
7 years, 6 months ago (2013-06-26 04:56:11 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-26 06:36:36 UTC) #6
Message was sent while issue was closed.
Change committed as 208659

Powered by Google App Engine
This is Rietveld 408576698