Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/android/loading/trace_recorder.py

Issue 1707363002: sandwich: Implements network condition on WPR server and browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@i00
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/android/loading/trace_recorder.py
diff --git a/tools/android/loading/trace_recorder.py b/tools/android/loading/trace_recorder.py
index 0da057ff7e0ecae934053e7b91e0d9e981f60ac3..de59b35fead9186658d9d46bec723a5d26b9ae31 100755
--- a/tools/android/loading/trace_recorder.py
+++ b/tools/android/loading/trace_recorder.py
@@ -31,14 +31,16 @@ import tracing
def MonitorUrl(connection, url, clear_cache=False,
- categories=tracing.DEFAULT_CATEGORIES):
+ categories=tracing.DEFAULT_CATEGORIES,
+ timeout=devtools_monitor.DEFAULT_TIMEOUT):
"""Monitor a URL via a trace recorder.
Args:
- connection: A device_monitor.DevToolsConnection instance.
+ connection: A devtools_monitor.DevToolsConnection instance.
url: url to navigate to as string.
clear_cache: boolean indicating if cache should be cleared before loading.
categories: List of tracing event categories to record.
+ timeout: Websocket timeout.
Returns:
loading_trace.LoadingTrace.
@@ -50,7 +52,7 @@ def MonitorUrl(connection, url, clear_cache=False,
if clear_cache:
connection.ClearCache()
connection.SendAndIgnoreResponse('Page.navigate', {'url': url})
- connection.StartMonitoring()
+ connection.StartMonitoring(timeout=timeout)
metadata = {'date': datetime.datetime.utcnow().isoformat(),
'seconds_since_epoch': time.time()}
return loading_trace.LoadingTrace(url, metadata, page, request, trace)
« tools/android/loading/devtools_monitor.py ('K') | « tools/android/loading/run_sandwich.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698