Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: chrome/renderer/worker_permission_client_proxy.cc

Issue 170733004: Avoid sync IPCs for FileSystem API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added missing early exit failure Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/render_messages.h" 5 #include "chrome/common/render_messages.h"
6 #include "chrome/renderer/worker_permission_client_proxy.h" 6 #include "chrome/renderer/worker_permission_client_proxy.h"
7 #include "content/public/renderer/render_frame.h" 7 #include "content/public/renderer/render_frame.h"
8 #include "content/public/renderer/render_thread.h" 8 #include "content/public/renderer/render_thread.h"
9 #include "ipc/ipc_sync_message_filter.h" 9 #include "ipc/ipc_sync_message_filter.h"
10 #include "third_party/WebKit/public/platform/WebPermissionCallbacks.h"
10 #include "third_party/WebKit/public/web/WebDocument.h" 11 #include "third_party/WebKit/public/web/WebDocument.h"
11 #include "third_party/WebKit/public/web/WebFrame.h" 12 #include "third_party/WebKit/public/web/WebFrame.h"
12 #include "third_party/WebKit/public/web/WebSecurityOrigin.h" 13 #include "third_party/WebKit/public/web/WebSecurityOrigin.h"
13 14
14 WorkerPermissionClientProxy::WorkerPermissionClientProxy( 15 WorkerPermissionClientProxy::WorkerPermissionClientProxy(
15 content::RenderFrame* render_frame, 16 content::RenderFrame* render_frame,
16 blink::WebFrame* frame) 17 blink::WebFrame* frame)
17 : routing_id_(render_frame->GetRoutingID()), 18 : routing_id_(render_frame->GetRoutingID()),
18 is_unique_origin_(false) { 19 is_unique_origin_(false) {
19 if (frame->document().securityOrigin().isUnique() || 20 if (frame->document().securityOrigin().isUnique() ||
(...skipping 24 matching lines...) Expand all
44 bool WorkerPermissionClientProxy::allowFileSystem() { 45 bool WorkerPermissionClientProxy::allowFileSystem() {
45 if (is_unique_origin_) 46 if (is_unique_origin_)
46 return false; 47 return false;
47 48
48 bool result = false; 49 bool result = false;
49 sync_message_filter_->Send(new ChromeViewHostMsg_AllowFileSystem( 50 sync_message_filter_->Send(new ChromeViewHostMsg_AllowFileSystem(
50 routing_id_, document_origin_url_, top_frame_origin_url_, &result)); 51 routing_id_, document_origin_url_, top_frame_origin_url_, &result));
51 return result; 52 return result;
52 } 53 }
53 54
55 void WorkerPermissionClientProxy::requestFileSystemAccess(
56 const blink::WebPermissionCallbacks& callbacks) {
57 bool result = false;
58 sync_message_filter_->Send(new ChromeViewHostMsg_AllowFileSystem(
59 routing_id_, document_origin_url_, top_frame_origin_url_, &result));
60 blink::WebPermissionCallbacks permission_callbacks(callbacks);
61 if (result) {
62 permission_callbacks.doAllow();
63 return;
64 }
65 permission_callbacks.doDeny();
66 }
67
54 bool WorkerPermissionClientProxy::allowIndexedDB( 68 bool WorkerPermissionClientProxy::allowIndexedDB(
55 const blink::WebString& name) { 69 const blink::WebString& name) {
56 if (is_unique_origin_) 70 if (is_unique_origin_)
57 return false; 71 return false;
58 72
59 bool result = false; 73 bool result = false;
60 sync_message_filter_->Send(new ChromeViewHostMsg_AllowIndexedDB( 74 sync_message_filter_->Send(new ChromeViewHostMsg_AllowIndexedDB(
61 routing_id_, document_origin_url_, top_frame_origin_url_, name, &result)); 75 routing_id_, document_origin_url_, top_frame_origin_url_, name, &result));
62 return result; 76 return result;
63 } 77 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698