Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1707293002: GN: Normalize the build directory path (Closed)

Created:
4 years, 10 months ago by hashimoto
Modified:
4 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Normalize the build directory path BUG=586906 TEST=ln -s /tmp out_tmp && out/gn/gn gen //out_tmp/Release Committed: https://crrev.com/62b5ce373ce17228a3c06f3e32ff329180e89921 Cr-Commit-Position: refs/heads/master@{#376288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M tools/gn/setup.cc View 3 chunks +35 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hashimoto
Thank you for taking care of the revert and your insightful advise. This time the ...
4 years, 10 months ago (2016-02-18 09:37:06 UTC) #2
brettw
lgtm
4 years, 10 months ago (2016-02-18 21:52:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707293002/1
4 years, 10 months ago (2016-02-18 21:57:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 22:11:10 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/62b5ce373ce17228a3c06f3e32ff329180e89921 Cr-Commit-Position: refs/heads/master@{#376288}
4 years, 10 months ago (2016-02-18 22:13:21 UTC) #8
hashimoto
4 years, 10 months ago (2016-02-22 09:39:36 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1723453002/ by hashimoto@chromium.org.

The reason for reverting is: Doesn't work when the build directory does not
exit..

Powered by Google App Engine
This is Rietveld 408576698