Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1707213002: Move SkTDArray to private. (Closed)

Created:
4 years, 10 months ago by bungeman-skia
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkTDArray to private. TBR=reed Moving to private is good. Committed: https://skia.googlesource.com/skia/+/a7e9f05119174848c6be5028568f46eb5e85398e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -386 lines) Patch
M gyp/core.gypi View 2 chunks +1 line, -1 line 0 comments Download
M gyp/xml.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkClipStack.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkDataTable.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkMultiPictureDraw.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPath.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkPathEffect.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkPathMeasure.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPathRef.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPixelRef.h View 1 chunk +2 lines, -2 lines 0 comments Download
D include/core/SkTDArray.h View 1 chunk +0 lines, -364 lines 0 comments Download
M include/pathops/SkPathOps.h View 1 chunk +1 line, -1 line 0 comments Download
A + include/private/SkTDArray.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/utils/SkLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkRTConf.h View 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkOSMenu.h View 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkTouchGesture.h View 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkWidget.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/views/SkWindow.h View 2 chunks +1 line, -1 line 0 comments Download
M include/xml/SkXMLWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommandLineFlags.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/skdiff.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/skdiff_main.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707213002/1
4 years, 10 months ago (2016-02-18 02:04:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 02:30:02 UTC) #6
bungeman-skia
4 years, 10 months ago (2016-02-18 16:14:09 UTC) #8
mtklein
lgtm
4 years, 10 months ago (2016-02-18 16:21:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707213002/1
4 years, 10 months ago (2016-02-18 16:21:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/6611)
4 years, 10 months ago (2016-02-18 16:23:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707213002/1
4 years, 10 months ago (2016-02-18 16:52:54 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 16:53:37 UTC) #18
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a7e9f05119174848c6be5028568f46eb5e85398e

Powered by Google App Engine
This is Rietveld 408576698