Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: components/crash/content/app/crashpad_win.cc

Issue 1707203002: win crashpad: Enable capture of indirect stack data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/crashpad_win.cc
diff --git a/components/crash/content/app/crashpad_win.cc b/components/crash/content/app/crashpad_win.cc
index 6c45bf3a16f07d9ba67acb0cfdc3d365a40cbb80..419a0511279e14687fe6c706b82da98915737e3f 100644
--- a/components/crash/content/app/crashpad_win.cc
+++ b/components/crash/content/app/crashpad_win.cc
@@ -75,6 +75,14 @@ base::FilePath PlatformCrashpadInitialization(bool initial_client,
base::FilePath exe_file;
CHECK(PathService::Get(base::FILE_EXE, &exe_file));
+ bool is_per_user_install =
+ crash_reporter_client->GetIsPerUserInstall(exe_file);
+ if (crash_reporter_client->GetShouldDumpLargerDumps(is_per_user_install)) {
+ crashpad::CrashpadInfo::GetCrashpadInfo()
+ ->set_gather_indirectly_referenced_memory(
Mark Mentovai 2016/02/18 03:57:38 It occurs to me that maybe we should have made thi
+ crashpad::TriState::kEnabled);
+ }
+
// If the handler is embedded in the binary (e.g. chrome, setup), we
// reinvoke it with --type=crashpad-handler. Otherwise, we use the
// standalone crashpad_handler.exe (for tests, etc.).
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698