win crashpad: Enable capture of indirect stack data

win crashpad: Enable capture of indirect stack data

This won't affect Stable based on https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_crash_reporter_client.cc&l=182 .

R=mark@chromium.org,siggi@chromium.org
BUG=587139, 586622
Committed: https://crrev.com/6b133b55a1a9c231e76f9d774cba1ff5644f99c6
Cr-Commit-Position: refs/heads/master@{#376098}

[scottmg, 2016-02-18 01:18:59]

Description was changed from

==========
Enable capture of indirect stack data

R=mark@chromium.org,siggi@chromium.org
BUG=587139
==========

to

==========
Enable capture of indirect stack data

This won't affect Stable based on
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...
.

R=mark@chromium.org,siggi@chromium.org
BUG=587139
==========

[scottmg, 2016-02-18 01:42:24]

Description was changed from

==========
Enable capture of indirect stack data

This won't affect Stable based on
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...
.

R=mark@chromium.org,siggi@chromium.org
BUG=587139
==========

to

==========
win crashpad: Enable capture of indirect stack data

This won't affect Stable based on
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...
.

R=mark@chromium.org,siggi@chromium.org
BUG=587139
==========

[scottmg, 2016-02-18 03:18:30]

Description was changed from

==========
win crashpad: Enable capture of indirect stack data

This won't affect Stable based on
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...
.

R=mark@chromium.org,siggi@chromium.org
BUG=587139
==========

to

==========
win crashpad: Enable capture of indirect stack data

This won't affect Stable based on
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...
.

R=mark@chromium.org,siggi@chromium.org
BUG=587139, 586622
==========

[Mark Mentovai, 2016-02-18 03:57:39]

LGTM

https://codereview.chromium.org/1707203002/diff/1/components/crash/content/ap...
File components/crash/content/app/crashpad_win.cc (right):

https://codereview.chromium.org/1707203002/diff/1/components/crash/content/ap...
components/crash/content/app/crashpad_win.cc:82:
->set_gather_indirectly_referenced_memory(
It occurs to me that maybe we should have made this a property of the database’s
settings instead of something each process needs to decide on by itself.

[scottmg, 2016-02-18 04:14:37]

On 2016/02/18 03:57:39, Mark Mentovai wrote:
> LGTM
> 
>
https://codereview.chromium.org/1707203002/diff/1/components/crash/content/ap...
> File components/crash/content/app/crashpad_win.cc (right):
> 
>
https://codereview.chromium.org/1707203002/diff/1/components/crash/content/ap...
> components/crash/content/app/crashpad_win.cc:82:
> ->set_gather_indirectly_referenced_memory(
> It occurs to me that maybe we should have made this a property of the
database’s
> settings instead of something each process needs to decide on by itself.

I could see it going either way. Maybe a process running with specific debug
flags wants to have it on, but not necessarily for all crashes saved in that
database.

[scottmg, 2016-02-18 04:14:42]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-02-18 04:15:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707203002/1

[commit-bot: I haz the power, 2016-02-18 04:52:05]

Description was changed from

==========
win crashpad: Enable capture of indirect stack data

This won't affect Stable based on
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...
.

R=mark@chromium.org,siggi@chromium.org
BUG=587139, 586622
==========

to

==========
win crashpad: Enable capture of indirect stack data

This won't affect Stable based on
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...
.

R=mark@chromium.org,siggi@chromium.org
BUG=587139, 586622
==========

[commit-bot: I haz the power, 2016-02-18 04:52:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-18 04:53:20]

Description was changed from

==========
win crashpad: Enable capture of indirect stack data

This won't affect Stable based on
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...
.

R=mark@chromium.org,siggi@chromium.org
BUG=587139, 586622
==========

to

==========
win crashpad: Enable capture of indirect stack data

This won't affect Stable based on
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...
.

R=mark@chromium.org,siggi@chromium.org
BUG=587139, 586622

Committed: https://crrev.com/6b133b55a1a9c231e76f9d774cba1ff5644f99c6
Cr-Commit-Position: refs/heads/master@{#376098}
==========

[commit-bot: I haz the power, 2016-02-18 04:53:21]

Patchset 1 (id:??) landed as
https://crrev.com/6b133b55a1a9c231e76f9d774cba1ff5644f99c6
Cr-Commit-Position: refs/heads/master@{#376098}