[Interpreter] Fix deopt when accumulator needs to be materialized.

[Interpreter] Fix deopt when accumulator needs to be materialized.

Moves the accumulator value on-heap to be restored in the
InterpreterNotifyDeopt handler rather than explicitly
setting the accumulator register. This allows it to be
materialized correctly if required.

BUG=v8:4678
LOG=N

Committed: https://crrev.com/9a26c1aee23943b37f411872169d6de284f58eb7
Cr-Commit-Position: refs/heads/master@{#34113}

[rmcilroy, 2016-02-17 22:46:10]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2016-02-17 22:46:19]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 22:46:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707133003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707133003/20001

[commit-bot: I haz the power, 2016-02-17 23:20:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 23:20:34]

Dry run: This issue passed the CQ dry run.

[Jarin, 2016-02-18 10:05:54]

jarin@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2016-02-18 10:05:54]

https://codereview.chromium.org/1707133003/diff/20001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1707133003/diff/20001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:1280: // Set the accumulator. If we are lazy deopting to a
catch handler,
Perhaps update the comment? (Maybe something like "Put the accumulator on the
stack, it will be popped by the NotifyDeoptimized stub (possibly after
materialization)."

https://codereview.chromium.org/1707133003/diff/20001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:2591: if (frame_it->kind() ==
TranslatedFrame::kInterpretedFunction) {
Good catch, I'm sorry about this!

[rmcilroy, 2016-02-18 11:49:22]

Patchset #2 (id:40001) has been deleted

[rmcilroy, 2016-02-18 11:50:35]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[rmcilroy, 2016-02-18 11:50:40]

https://codereview.chromium.org/1707133003/diff/20001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1707133003/diff/20001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:1280: // Set the accumulator. If we are lazy deopting to a
catch handler,
On 2016/02/18 10:05:54, Jarin wrote:
> Perhaps update the comment? (Maybe something like "Put the accumulator on the
> stack, it will be popped by the NotifyDeoptimized stub (possibly after
> materialization)."

Done.

https://codereview.chromium.org/1707133003/diff/20001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:2591: if (frame_it->kind() ==
TranslatedFrame::kInterpretedFunction) {
On 2016/02/18 10:05:54, Jarin wrote:
> Good catch, I'm sorry about this!

Acknowledged.

[commit-bot: I haz the power, 2016-02-18 11:50:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707133003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707133003/60001

[rmcilroy, 2016-02-18 11:50:50]

Thanks for the test!

[rmcilroy, 2016-02-18 11:51:49]

Patchset #2 (id:60001) has been deleted

[rmcilroy, 2016-02-18 11:52:08]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 11:52:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707133003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707133003/80001

[commit-bot: I haz the power, 2016-02-18 12:12:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 12:13:00]

Dry run: This issue passed the CQ dry run.

[Jarin, 2016-02-18 12:36:29]

lgtm. Thanks!

[rmcilroy, 2016-02-18 12:46:16]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-02-18 12:46:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707133003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707133003/80001

[commit-bot: I haz the power, 2016-02-18 12:50:02]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-02-18 12:50:47]

Description was changed from

==========
[Interpreter] Fix deopt when accumulator needs to be materialized.

Moves the accumulator value on-heap to be restored in the
InterpreterNotifyDeopt handler rather than explicitly
setting the accumulator register. This allows it to be
materialized correctly if required.

BUG=v8:4678
LOG=N
==========

to

==========
[Interpreter] Fix deopt when accumulator needs to be materialized.

Moves the accumulator value on-heap to be restored in the
InterpreterNotifyDeopt handler rather than explicitly
setting the accumulator register. This allows it to be
materialized correctly if required.

BUG=v8:4678
LOG=N

Committed: https://crrev.com/9a26c1aee23943b37f411872169d6de284f58eb7
Cr-Commit-Position: refs/heads/master@{#34113}
==========

[commit-bot: I haz the power, 2016-02-18 12:50:48]

Patchset 2 (id:??) landed as
https://crrev.com/9a26c1aee23943b37f411872169d6de284f58eb7
Cr-Commit-Position: refs/heads/master@{#34113}