Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/extensions/api/image_writer_private/test_utils.cc

Issue 170713007: Resubmit of 149313003: Significantly cleans up the ImageWriter Operation class and subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes comments. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/image_writer_private/test_utils.cc
diff --git a/chrome/browser/extensions/api/image_writer_private/test_utils.cc b/chrome/browser/extensions/api/image_writer_private/test_utils.cc
index 999898bd9029da0a3c01d01735977336fe93bf97..29c5b5cc3e467aabb2f6152bcc89ca7ef7ad2e80 100644
--- a/chrome/browser/extensions/api/image_writer_private/test_utils.cc
+++ b/chrome/browser/extensions/api/image_writer_private/test_utils.cc
@@ -45,16 +45,18 @@ class ImageWriterFakeImageBurnerClient
private:
BurnFinishedHandler burn_finished_handler_;
BurnProgressUpdateHandler burn_progress_update_handler_;
-
};
} // namespace
#endif
MockOperationManager::MockOperationManager() : OperationManager(NULL) {}
+MockOperationManager::MockOperationManager(Profile* profile)
+ : OperationManager(profile) {}
MockOperationManager::~MockOperationManager() {}
-ImageWriterUnitTestBase::ImageWriterUnitTestBase() {}
+ImageWriterUnitTestBase::ImageWriterUnitTestBase()
+ : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}
ImageWriterUnitTestBase::~ImageWriterUnitTestBase() {}
void ImageWriterUnitTestBase::SetUp() {
@@ -87,31 +89,6 @@ void ImageWriterUnitTestBase::TearDown() {
#endif
}
-bool ImageWriterUnitTestBase::CompareImageAndDevice() {
- scoped_ptr<char[]> image_buffer(new char[kTestFileSize]);
- scoped_ptr<char[]> device_buffer(new char[kTestFileSize]);
-
- while (true) {
- int image_bytes_read = ReadFile(test_image_path_,
- image_buffer.get(),
- kTestFileSize);
- int device_bytes_read = ReadFile(test_device_path_,
- device_buffer.get(),
- kTestFileSize);
-
- if (image_bytes_read != device_bytes_read)
- return false;
-
- if (image_bytes_read == 0)
- return true;
-
- if (memcmp(image_buffer.get(), device_buffer.get(), image_bytes_read) != 0)
- return false;
- }
-
- return false;
-}
-
bool ImageWriterUnitTestBase::FillFile(const base::FilePath& file,
const int pattern,
const int length) {

Powered by Google App Engine
This is Rietveld 408576698