Resubmit of 149313003: Significantly cleans up the ImageWriter Operation class and subclasses.

chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "chrome/browser/extensions/api/file_handlers/app_file_handler_util.h"
 #include "chrome/browser/extensions/api/image_writer_private/error_messages.h"
 #include "chrome/browser/extensions/api/image_writer_private/image_writer_private_api.h"
 #include "chrome/browser/extensions/api/image_writer_private/operation_manager.h"
 
@@ skipping 13 matching lines @@
   scoped_ptr<image_writer_api::WriteFromUrl::Params> params(
       image_writer_api::WriteFromUrl::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   GURL url(params->image_url);
   if (!url.is_valid()) {
     error_ = image_writer::error::kUrlInvalid;
     return false;
   }
 
-#if defined(OS_CHROMEOS)
-  // The Chrome OS temporary partition is too small for Chrome OS images, thus
-  // we must always use the downloads folder.
-  bool save_image_as_download = true;
-#else
-  bool save_image_as_download = false;
-  if (params->options.get() && params->options->save_as_download.get()) {
-    save_image_as_download = true;
-  }
-#endif
-
   std::string hash;
   if (params->options.get() && params->options->image_hash.get()) {
     hash = *params->options->image_hash;
   }
 
   image_writer::OperationManager::Get(GetProfile())->StartWriteFromUrl(
       extension_id(),
       url,
-      render_view_host(),
       hash,
-      save_image_as_download,
       params->storage_unit_id,
       base::Bind(&ImageWriterPrivateWriteFromUrlFunction::OnWriteStarted,
                  this));
   return true;
 }
 
 void ImageWriterPrivateWriteFromUrlFunction::OnWriteStarted(
     bool success,
     const std::string& error) {
   if (!success) {
@@ skipping 16 matching lines @@
   std::string filesystem_path;
   std::string storage_unit_id;
 
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &storage_unit_id));
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(1, &filesystem_name));
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(2, &filesystem_path));
 
   base::FilePath path;
 
   if (!extensions::app_file_handler_util::ValidateFileEntryAndGetPath(
-      filesystem_name,
-      filesystem_path,
-      render_view_host_,
-      &path,
-      &error_))
+           filesystem_name,
+           filesystem_path,
+           render_view_host(),
+           &path,
+           &error_))
     return false;
 
   image_writer::OperationManager::Get(GetProfile())->StartWriteFromFile(
       extension_id(),
       path,
       storage_unit_id,
       base::Bind(&ImageWriterPrivateWriteFromFileFunction::OnWriteStarted,
                  this));
   return true;
 }
@@ skipping 87 matching lines @@
       image_writer_api::ListRemovableStorageDevices::Results::Create(
         device_list.get()->data);
     SendResponse(true);
   } else {
     error_ = image_writer::error::kDeviceListError;
     SendResponse(false);
   }
 }
 
 }  // namespace extensions