Issue 170713006: installPixels returns true if null-pixels -- devolving to setConfig

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 170713006: installPixels returns true if null-pixels -- devolving to setConfig (Closed)

Created:
6 years, 10 months ago by reed1

Modified:
6 years, 10 months ago

Reviewers:
bsalomon, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

installPixels returns true if null-pixels -- devolving to setConfig fixes assumptions in chrome's ui_unittests: RenderTextTest.SelectionKeepsLigatures Committed: http://code.google.com/p/skia/source/detail?r=13492

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/core/SkBitmap.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/170713006/1

6 years, 10 months ago (2014-02-18 21:22:07 UTC) #5

Message was sent while issue was closed.

Change committed as 13492

Expand Messages | Collapse Messages