Remove DisableCompositingQueryAsserts from Interals.cpp

Remove DisableCompositingQueryAsserts from Interals.cpp

We need to update compositing before poking the animation engine.

BUG=343760
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167437

[abarth-chromium, 2014-02-18 18:25:02]

This CL depends on https://codereview.chromium.org/168193002/

[ojan, 2014-02-18 20:46:23]

lgtm


On Tue, Feb 18, 2014 at 10:25 AM, <abarth@chromium.org> wrote:

> Reviewers: ojan, dstockwell,
>
> Message:
> This CL depends on https://codereview.chromium.org/168193002/
>
> Description:
> Remove DisableCompositingQueryAsserts from Interals.cpp
>
> We need to update compositing before poking the animation engine.
>
> BUG=343760
>
> Please review this at https://codereview.chromium.org/170713003/
>
> SVN Base: svn://svn.chromium.org/blink/trunk
>
> Affected files (+1, -3 lines):
>   Source/core/testing/Internals.cpp
>
>
> Index: Source/core/testing/Internals.cpp
> diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/
> Internals.cpp
> index 60619543c27dac76fbb0c2b0e0a11d745c490bdf..
> eaab2bf5102018a00d5856df6ecd9b69e8eaf33e 100644
> --- a/Source/core/testing/Internals.cpp
> +++ b/Source/core/testing/Internals.cpp
> @@ -484,9 +484,7 @@ void Internals::pauseAnimations(double pauseTime,
> ExceptionState& exceptionState
>          return;
>      }
>
> -    // https://code.google.com/p/chromium/issues/detail?id=343760
> -    DisableCompositingQueryAsserts disabler;
> -
> +    frame()->view()->updateLayoutAndStyleForPainting();
>      frame()->document()->timeline()->pauseAnimationsForTesting(
> pauseTime);
>      frame()->document()->transitionTimeline()->pauseAnimationsForTesting(
> pauseTime);
>  }
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dstockwell, 2014-02-18 21:50:19]

lgtm

I think we may be able to remove the queries in these cases entirely. If that's
possible I'll come back and clean this up when I fix the underlying issues in
bug 339847.

[abarth-chromium, 2014-02-19 00:46:29]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-02-19 00:46:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/170713003/1

[commit-bot: I haz the power, 2014-02-19 03:42:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 03:42:54]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[abarth-chromium, 2014-02-19 18:14:58]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-02-19 21:49:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/170713003/1

[commit-bot: I haz the power, 2014-02-19 22:55:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/170713003/1

[commit-bot: I haz the power, 2014-02-19 23:22:00]

Change committed as 167437