Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2787)

Issue 1707103004: Add utility method to wait for bookmark model to be loaded in tests. (Closed)

Created:
4 years, 10 months ago by newt (away)
Modified:
4 years, 10 months ago
Reviewers:
Ian Wen, gone
CC:
chromium-reviews, noyau+watch_chromium.org, browser-components-watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add utility method to wait for bookmark model to be loaded in tests. BUG=583477 Committed: https://crrev.com/eb03cb632cb741486a45d84b32212720f1f649f8 Cr-Commit-Position: refs/heads/master@{#376077}

Patch Set 1 #

Messages

Total messages: 11 (4 generated)
newt (away)
PTAL
4 years, 10 months ago (2016-02-18 00:27:10 UTC) #2
Ian Wen
lgtm. The native model is per-profile KeyedService, which won't be affected even if we remove ...
4 years, 10 months ago (2016-02-18 00:48:28 UTC) #3
newt (away)
dfalcantara@chromium.org: for tests OWNERS
4 years, 10 months ago (2016-02-18 00:51:21 UTC) #5
gone
rs OWNERS lgtm
4 years, 10 months ago (2016-02-18 02:06:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707103004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707103004/1
4 years, 10 months ago (2016-02-18 02:07:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 02:42:53 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 02:44:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb03cb632cb741486a45d84b32212720f1f649f8
Cr-Commit-Position: refs/heads/master@{#376077}

Powered by Google App Engine
This is Rietveld 408576698