Fix find in page behavior

Fix find in page behavior

Fix find in page behavior when removing, then re-inserting the character
used in a previous find operation, as described in issue 294160.
In order to fix this, once TextFinder gets the signal to stop finding, also
reset the active match Range information.

Based on work by a.bah@samsung.com.

BUG=294160
Committed: https://crrev.com/39ef271c5d9f560e72db45cb1ddaffd20927ebb8
Cr-Commit-Position: refs/heads/master@{#376525}

[rwlbuis, 2016-02-17 22:27:02]

Description was changed from

==========
Find in Page WIP

BUG=294160
==========

to

==========
Fix find in page behavior

Fix find in page behavior when removing, then re-inserting a single character
from a previous find operation, as
described in issue 294160. In order to fix this, once
TextFinder gets the signal to stop finding, also reset
the active match Range information.

Based on work by a.bah@samsung.com.

BUG=294160
==========

[rwlbuis, 2016-02-17 22:27:52]

Description was changed from

==========
Fix find in page behavior

Fix find in page behavior when removing, then re-inserting a single character
from a previous find operation, as
described in issue 294160. In order to fix this, once
TextFinder gets the signal to stop finding, also reset
the active match Range information.

Based on work by a.bah@samsung.com.

BUG=294160
==========

to

==========
Fix find in page behavior

Fix find in page behavior when removing, then re-inserting the character
used in a previous find operation, as described in issue 294160.
In order to fix this, once TextFinder gets the signal to stop finding, also
reset the active match Range information.

Based on work by a.bah@samsung.com.

BUG=294160
==========

[rwlbuis, 2016-02-17 23:47:20]

rob.buis@samsung.com changed reviewers:
+ tkent@chromium.org

[rwlbuis, 2016-02-17 23:47:21]

PTAL.

[tkent, 2016-02-18 23:22:52]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org
- tkent@chromium.org

[tkent, 2016-02-18 23:23:05]

+yosin@

[yosin_UTC9, 2016-02-19 02:03:19]

On 2016/02/18 at 23:23:05, tkent wrote:
> +yosin@

Oh, crbug.com doesn't work now. So, I can't check details of the issue.
I'll visit this patch once crbug.com alive.

[yosin_UTC9, 2016-02-19 09:37:13]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2016-02-19 09:37:13]

lgtm

The code change is just adding to call |resetActiveMatch()| in
|TextFinder::stopFindingAndClearSelection()|


+tkent@ for Source/web chagnes.

[tkent, 2016-02-19 09:44:12]

lgtm

[rwlbuis, 2016-02-19 10:08:26]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-02-19 10:08:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707083002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707083002/20001

[commit-bot: I haz the power, 2016-02-19 14:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 14:08:25]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rwlbuis, 2016-02-19 14:09:05]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-02-19 14:11:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707083002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707083002/20001

[commit-bot: I haz the power, 2016-02-19 17:32:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 17:32:19]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rwlbuis, 2016-02-19 18:25:16]

rob.buis@samsung.com changed reviewers:
+ boliu@chromium.org, sgurun@chromium.org

[rwlbuis, 2016-02-19 18:25:17]

@sgurun, bulio PTAL for the WebViewAsynchronousFindApisTest.java change.

[boliu, 2016-02-19 18:34:56]

On 2016/02/19 18:25:17, rwlbuis wrote:
> @sgurun, bulio PTAL for the WebViewAsynchronousFindApisTest.java change.

lgtm

[rwlbuis, 2016-02-19 18:49:19]

On 2016/02/19 18:34:56, boliu wrote:
> On 2016/02/19 18:25:17, rwlbuis wrote:
> > @sgurun, bulio PTAL for the WebViewAsynchronousFindApisTest.java change.
> 
> lgtm

Thanks!

[rwlbuis, 2016-02-19 18:49:24]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-02-19 18:49:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1707083002/#ps40001
(title: "Fix android_webview test")

[commit-bot: I haz the power, 2016-02-19 18:51:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707083002/40001

[commit-bot: I haz the power, 2016-02-19 20:36:48]

Description was changed from

==========
Fix find in page behavior

Fix find in page behavior when removing, then re-inserting the character
used in a previous find operation, as described in issue 294160.
In order to fix this, once TextFinder gets the signal to stop finding, also
reset the active match Range information.

Based on work by a.bah@samsung.com.

BUG=294160
==========

to

==========
Fix find in page behavior

Fix find in page behavior when removing, then re-inserting the character
used in a previous find operation, as described in issue 294160.
In order to fix this, once TextFinder gets the signal to stop finding, also
reset the active match Range information.

Based on work by a.bah@samsung.com.

BUG=294160
==========

[commit-bot: I haz the power, 2016-02-19 20:36:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-19 20:38:08]

Description was changed from

==========
Fix find in page behavior

Fix find in page behavior when removing, then re-inserting the character
used in a previous find operation, as described in issue 294160.
In order to fix this, once TextFinder gets the signal to stop finding, also
reset the active match Range information.

Based on work by a.bah@samsung.com.

BUG=294160
==========

to

==========
Fix find in page behavior

Fix find in page behavior when removing, then re-inserting the character
used in a previous find operation, as described in issue 294160.
In order to fix this, once TextFinder gets the signal to stop finding, also
reset the active match Range information.

Based on work by a.bah@samsung.com.

BUG=294160

Committed: https://crrev.com/39ef271c5d9f560e72db45cb1ddaffd20927ebb8
Cr-Commit-Position: refs/heads/master@{#376525}
==========

[commit-bot: I haz the power, 2016-02-19 20:38:09]

Patchset 3 (id:??) landed as
https://crrev.com/39ef271c5d9f560e72db45cb1ddaffd20927ebb8
Cr-Commit-Position: refs/heads/master@{#376525}