Serialize and resynthesize variable initializers.

Serialize and resynthesize variable initializers.

We need them to be able to bind back elements in DeclarationResolver in
code like: var v = {'1': () => 10};

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/2329db5f4ab1a002de4a449e5360a3668994804e

[Paul Berry, 2016-02-17 21:15:30]

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:1364: @Id(10)
Don't change the ids of existing getters--it messes up forward/backward
compatibility.  Instead, just assign the new field to the next unused id (12 in
this case).

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:1798: @Id(9)
Similar issue here.

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_elements.dart (right):

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:709: if (parameter is!
Member && parameter.initializer != null) {
Can you include a comment explaining why we want to skip this when parameter is!
Member?  It's not obvious to me.

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:928: //      b.initializer
= new UnlinkedExecutableBuilder(
Was this commented out code left here unintentionally?

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:1014: } else if
(element.isSynthetic &&
It seems like this code shouldn't be reachable.

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:868: if (original is!
Member) {
Again, why should we skip this code if original is Member?

[scheglov, 2016-02-17 21:27:51]

PTAL

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:1364: @Id(10)
On 2016/02/17 21:15:29, Paul Berry wrote:
> Don't change the ids of existing getters--it messes up forward/backward
> compatibility.  Instead, just assign the new field to the next unused id (12
in
> this case).

Done.

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:1798: @Id(9)
On 2016/02/17 21:15:29, Paul Berry wrote:
> Similar issue here.

Done.

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_elements.dart (right):

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:709: if (parameter is!
Member && parameter.initializer != null) {
On 2016/02/17 21:15:30, Paul Berry wrote:
> Can you include a comment explaining why we want to skip this when parameter
is!
> Member?  It's not obvious to me.

Done.

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:928: //      b.initializer
= new UnlinkedExecutableBuilder(
On 2016/02/17 21:15:30, Paul Berry wrote:
> Was this commented out code left here unintentionally?

This code should be removed.
Thanks.

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:1014: } else if
(element.isSynthetic &&
On 2016/02/17 21:15:30, Paul Berry wrote:
> It seems like this code shouldn't be reachable.

You're right.
I don't remember why I added it, but yes - it is not used.
Removing it now.

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1707073002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:868: if (original is!
Member) {
On 2016/02/17 21:15:30, Paul Berry wrote:
> Again, why should we skip this code if original is Member?

I've added the explanation comment.

[Paul Berry, 2016-02-17 21:29:27]

lgtm, thanks!

[scheglov, 2016-02-17 21:32:46]

Description was changed from

==========
Serialize and resynthesize variable initializers.

We need them to be able to bind back elements in DeclarationResolver in
code like: var v = {'1': () => 10};

R=paulberry@google.com
BUG=
==========

to

==========
Serialize and resynthesize variable initializers.

We need them to be able to bind back elements in DeclarationResolver in
code like: var v = {'1': () => 10};

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/2329db5f4ab1a002de4a449e5360a3668994804e
==========

[scheglov, 2016-02-17 21:32:48]

Committed patchset #2 (id:20001) manually as
2329db5f4ab1a002de4a449e5360a3668994804e (presubmit successful).