Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1707053002: Delete KTX tests to fix Android build (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
scroggo, djsollen, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete SkImageDecoderGenerator as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -373 lines) Patch
D bench/ETCBitmapBench.cpp View 1 chunk +0 lines, -238 lines 0 comments Download
M src/images/SkImageDecoder_ktx.cpp View 1 1 chunk +0 lines, -98 lines 0 comments Download
M tests/KtxTest.cpp View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
msarett
4 years, 10 months ago (2016-02-17 20:39:53 UTC) #3
djsollen
https://codereview.chromium.org/1707053002/diff/1/src/images/SkImageDecoder_ktx.cpp File src/images/SkImageDecoder_ktx.cpp (left): https://codereview.chromium.org/1707053002/diff/1/src/images/SkImageDecoder_ktx.cpp#oldcode427 src/images/SkImageDecoder_ktx.cpp:427: return new SkImageDecoderGenerator(bm.info(), decoder, data); remove this class definition ...
4 years, 10 months ago (2016-02-17 20:41:41 UTC) #4
msarett
https://codereview.chromium.org/1707053002/diff/1/src/images/SkImageDecoder_ktx.cpp File src/images/SkImageDecoder_ktx.cpp (left): https://codereview.chromium.org/1707053002/diff/1/src/images/SkImageDecoder_ktx.cpp#oldcode427 src/images/SkImageDecoder_ktx.cpp:427: return new SkImageDecoderGenerator(bm.info(), decoder, data); On 2016/02/17 20:41:41, djsollen ...
4 years, 10 months ago (2016-02-17 20:42:59 UTC) #5
djsollen
lgtm
4 years, 10 months ago (2016-02-17 20:46:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707053002/20001
4 years, 10 months ago (2016-02-17 20:48:10 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 21:10:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/82709da1221357d4d5c38aa5a39fc301129ccf7d

Powered by Google App Engine
This is Rietveld 408576698